Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tls: fix performance regression in convertALPNProtocols() #43250

Merged

Commits on Jun 3, 2022

  1. tls: fix performance regression in convertALPNProtocols()

    `isUint8Array()` covers instances of `Buffer`
    `isArrayBufferView()` path is cold and not worth additional check
    
    PR-URL: nodejs#43250
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    LiviaMedeiros committed Jun 3, 2022
    Configuration menu
    Copy the full SHA
    386c7e1 View commit details
    Browse the repository at this point in the history