Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

module: add isBuiltin method #43396

Merged
merged 24 commits into from Jul 8, 2022
Merged

module: add isBuiltin method #43396

merged 24 commits into from Jul 8, 2022

Commits on Jun 14, 2022

  1. module: add isBuiltIn method

    @hemanth
    hemanth committed Jun 14, 2022
    Configuration menu
    Copy the full SHA
    ec1f95a View commit details
    Browse the repository at this point in the history

  2. Use regex instead 

    Co-authored-by: Jordan Harband <ljharb@gmail.com>
    @hemanth @ljharb
    hemanth and ljharb committed Jun 14, 2022
    Configuration menu
    Copy the full SHA
    2376045 View commit details
    Browse the repository at this point in the history

  3. using primordial instead 

    Co-authored-by: Jordan Harband <ljharb@gmail.com>
    @hemanth @ljharb
    hemanth and ljharb committed Jun 14, 2022
    Configuration menu
    Copy the full SHA
    06c135a View commit details
    Browse the repository at this point in the history

  4. importing StringPrototypeReplace

    @hemanth
    hemanth committed Jun 14, 2022
    Configuration menu
    Copy the full SHA
    62a4280 View commit details
    Browse the repository at this point in the history

  5. doc: add isBuiltIn

    @hemanth
    hemanth committed Jun 14, 2022
    Configuration menu
    Copy the full SHA
    57f5686 View commit details
    Browse the repository at this point in the history

Commits on Jun 15, 2022

  1. fix: use String

    @hemanth
    hemanth committed Jun 15, 2022
    Configuration menu
    Copy the full SHA
    55916da View commit details
    Browse the repository at this point in the history

  2. using the placeholder REPLACEME 

    Co-authored-by: mscdex <mscdex@users.noreply.github.com>
    @hemanth @mscdex
    hemanth and mscdex committed Jun 15, 2022
    Configuration menu
    Copy the full SHA
    075ae02 View commit details
    Browse the repository at this point in the history

Commits on Jun 16, 2022

  1. prefix to tests 

    Co-authored-by: mscdex <mscdex@users.noreply.github.com>
    @hemanth @mscdex
    hemanth and mscdex committed Jun 16, 2022
    Configuration menu
    Copy the full SHA
    7a08b8f View commit details
    Browse the repository at this point in the history

  2. avoid reassigning function args 

    Co-authored-by: Jordan Harband <ljharb@gmail.com>
    @hemanth @ljharb
    hemanth and ljharb committed Jun 16, 2022
    Configuration menu
    Copy the full SHA
    8c78587 View commit details
    Browse the repository at this point in the history

  3. fix: falsy value assertion

    @hemanth
    hemanth committed Jun 16, 2022
    Configuration menu
    Copy the full SHA
    cfc1a07 View commit details
    Browse the repository at this point in the history

Commits on Jun 19, 2022

  1. fix: also support scheme only modules

    @hemanth
    hemanth committed Jun 19, 2022
    Configuration menu
    Copy the full SHA
    8ab8589 View commit details
    Browse the repository at this point in the history

  2. removed auto imported console. 

    Co-authored-by: mscdex <mscdex@users.noreply.github.com>
    @hemanth @mscdex
    hemanth and mscdex committed Jun 19, 2022
    Configuration menu
    Copy the full SHA
    deb9010 View commit details
    Browse the repository at this point in the history

  3. fix: prefix only module checks

    @hemanth
    hemanth committed Jun 19, 2022
    Configuration menu
    Copy the full SHA
    420c8eb View commit details
    Browse the repository at this point in the history

  4. proper check for prefixes 

    Co-authored-by: mscdex <mscdex@users.noreply.github.com>
    @hemanth @mscdex
    hemanth and mscdex committed Jun 19, 2022
    Configuration menu
    Copy the full SHA
    4bab085 View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2022

  1. Update lib/internal/modules/cjs/loader.js 

    Co-authored-by: Jordan Harband <ljharb@gmail.com>
    @hemanth @ljharb
    hemanth and ljharb committed Jun 21, 2022
    Configuration menu
    Copy the full SHA
    9a4fe4a View commit details
    Browse the repository at this point in the history

Commits on Jun 23, 2022

  1. Update test/parallel/test-module-isBuiltIn.js 

    Co-authored-by: Michaël Zasso <targos@protonmail.com>
    @hemanth @targos
    hemanth and targos committed Jun 23, 2022
    Configuration menu
    Copy the full SHA
    3b2cd57 View commit details
    Browse the repository at this point in the history

  2. fix: using Set for better perf

    @hemanth
    hemanth committed Jun 23, 2022
    Configuration menu
    Copy the full SHA
    eafd131 View commit details
    Browse the repository at this point in the history

  3. fix: avoid mutation

    @hemanth
    hemanth committed Jun 23, 2022
    Configuration menu
    Copy the full SHA
    1e81d07 View commit details
    Browse the repository at this point in the history

  4. use slice rather 

    Co-authored-by: mscdex <mscdex@users.noreply.github.com>
    @hemanth @mscdex
    hemanth and mscdex committed Jun 23, 2022
    Configuration menu
    Copy the full SHA
    0910fe0 View commit details
    Browse the repository at this point in the history

  5. fix: avoid assignment. 

    Co-authored-by: mscdex <mscdex@users.noreply.github.com>
    @hemanth @mscdex
    hemanth and mscdex committed Jun 23, 2022
    Configuration menu
    Copy the full SHA
    1e7b74f View commit details
    Browse the repository at this point in the history

Commits on Jun 24, 2022

  1. allBuiltins as a Set 

    Co-authored-by: Feng Yu <F3n67u@outlook.com>
    @hemanth @F3n67u
    hemanth and F3n67u committed Jun 24, 2022
    Configuration menu
    Copy the full SHA
    15b71f3 View commit details
    Browse the repository at this point in the history

  2. chore: naming it isBuiltin instead & using flatMap

    @hemanth
    hemanth committed Jun 24, 2022
    Configuration menu
    Copy the full SHA
    70e823a View commit details
    Browse the repository at this point in the history

  3. doc: isBuiltin 

    Co-authored-by: mscdex <mscdex@users.noreply.github.com>
    @hemanth @mscdex
    hemanth and mscdex committed Jun 24, 2022
    Configuration menu
    Copy the full SHA
    fc63117 View commit details
    Browse the repository at this point in the history

  4. chore: rename to isBuiltin

    @hemanth
    hemanth committed Jun 24, 2022
    Configuration menu
    Copy the full SHA
    b6033d2 View commit details
    Browse the repository at this point in the history