crypto: handle webcrypto generateKey() usages edge case #43454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
panva
added
crypto
|
Review requested:
|
panva
force-pushed
the
webcrypto-empty-usage-check
branch
from
fe50533
to
d066a1c
Compare
tniessen
approved these changes
Jun 17, 2022
panva
added
author ready
github-actions
bot
removed
the
request-ci
34 tasks
30 tasks
This was referenced Jun 20, 2022
panva
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 84db3e7 |
targos
pushed a commit
that referenced
this pull request
Jul 12, 2022
PR-URL: #43454 Reviewed-By: Tobias Nießen <tniessen@tnie.de>
targos
pushed a commit
that referenced
this pull request
Jul 20, 2022
PR-URL: #43454 Reviewed-By: Tobias Nießen <tniessen@tnie.de>
targos
pushed a commit
that referenced
this pull request
Jul 31, 2022
PR-URL: #43454 Reviewed-By: Tobias Nießen <tniessen@tnie.de>
guangwong
pushed a commit
to noslate-project/node
that referenced
this pull request
Oct 10, 2022
PR-URL: nodejs/node#43454 Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per spec:
chrome:
The current check has an edge case with signing algorithms where only public key usages could be provided.