Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: remove windows xperf from tierlist #43607

Closed
wants to merge 1 commit into from

Conversation

tony-go
Copy link
Member

@tony-go tony-go commented Jun 28, 2022

Hey 👋

Context

The diagnostic working group currently works on an initiative to re-evaluate the diagnostic tooling list and its maturity.

Note: it's normally the last batch of updates before closing the issue.

Updated

In the previous instance, we examined the case of the Windows xperf module: issue link.

As anyone in the instance has an idea about a potential usage in the field, we decided to remove it. As said in the previous PRs, we prefer to have a list that contains fewer items but is trustable.

But in case you have a different opinion, please share your thoughts in this PR 🙏.

Discuss

As usual, feel free to share your thoughts on that and your experience with this tool.

With love ❤️

cc @nodejs/diagnostics

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/tsc

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Jun 28, 2022
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tony-go tony-go force-pushed the remove-win-xperf-tierlist branch from 608e9e2 to e92c7b7 Compare July 2, 2022 18:33
@tony-go
Copy link
Member Author

tony-go commented Jul 2, 2022

Rebased ↪️

lpinca pushed a commit that referenced this pull request Jul 3, 2022
PR-URL: #43607
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
@lpinca
Copy link
Member

lpinca commented Jul 3, 2022

Landed in dca76e7.

@lpinca lpinca closed this Jul 3, 2022
targos pushed a commit that referenced this pull request Jul 12, 2022
PR-URL: #43607
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
targos pushed a commit that referenced this pull request Jul 20, 2022
PR-URL: #43607
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
targos pushed a commit that referenced this pull request Jul 31, 2022
PR-URL: #43607
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
PR-URL: nodejs/node#43607
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants