Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: mark test-net-connect-reset-until-connected flaky on freebsd #43613

Merged
merged 1 commit into from
Jul 12, 2022
Merged

test: mark test-net-connect-reset-until-connected flaky on freebsd #43613

merged 1 commit into from
Jul 12, 2022

Conversation

F3n67u
Copy link
Member

@F3n67u F3n67u commented Jun 29, 2022

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Jun 29, 2022
@F3n67u F3n67u added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 29, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 29, 2022
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/44954/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/45232/

@F3n67u F3n67u added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Jul 12, 2022
@F3n67u
Copy link
Member Author

F3n67u commented Jul 12, 2022

found another failure today: https://ci.nodejs.org/job/node-test-commit-freebsd/44846/nodes=freebsd12-x64/testReport/junit/(root)/test/parallel_test_net_connect_reset_until_connected/

@F3n67u
Copy link
Member Author

F3n67u commented Jul 12, 2022

One collaborator approval is enough if the pull request has been open for more than seven days.

according to this policy, I add commit queue label to this pr trying to land it.

@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 12, 2022
@nodejs-github-bot nodejs-github-bot merged commit 71cbab6 into nodejs:main Jul 12, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in 71cbab6

@F3n67u F3n67u deleted the fb-test-net-connect-reset-until-connected branch July 12, 2022 03:52
targos pushed a commit that referenced this pull request Jul 12, 2022
@F3n67u @targos
test: mark test-net-connect-reset-until-connected flaky on freebsd
294f0ef 
PR-URL: #43613
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@targos targos mentioned this pull request Jul 12, 2022
Merged
targos pushed a commit that referenced this pull request Jul 20, 2022
@F3n67u @targos
test: mark test-net-connect-reset-until-connected flaky on freebsd
25291b8 
PR-URL: #43613
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit that referenced this pull request Jul 31, 2022
@F3n67u @targos
test: mark test-net-connect-reset-until-connected flaky on freebsd
a5e1620 
PR-URL: #43613
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@targos targos mentioned this pull request Aug 3, 2022
Merged
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
@F3n67u @guangwong
test: mark test-net-connect-reset-until-connected flaky on freebsd
5dfe58d 
PR-URL: nodejs/node#43613
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@F3n67u @nodejs-github-bot @lpinca