test: mark test-worker-http2-stream-terminate flaky on all platforms #43620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
F3n67u
added
fast-track
|
Fast-track has been requested by @F3n67u. Please 👍 to approve. |
LiviaMedeiros
approved these changes
Jun 29, 2022
F3n67u
changed the title
F3n67u
force-pushed
the
flaky-test-worker-http2-stream-terminate
branch
from
91ca85d
to
9a21438
Compare
good catch. fixed. |
RaisinTen
added
the
author ready
This comment was marked as outdated.
This comment was marked as outdated.
targos
approved these changes
Jun 30, 2022
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
tniessen
approved these changes
Jul 1, 2022
|
Hi. collaborators! could you help to resume ci? |
This comment was marked as outdated.
This comment was marked as outdated.
|
Please help to resume ci again. our old flaky friend |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
LiviaMedeiros
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 2bd940c |
23 tasks
targos
pushed a commit
that referenced
this pull request
Jul 12, 2022
PR-URL: #43620 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
targos
pushed a commit
that referenced
this pull request
Jul 20, 2022
PR-URL: #43620 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
targos
pushed a commit
that referenced
this pull request
Jul 31, 2022
PR-URL: #43620 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
guangwong
pushed a commit
to noslate-project/node
that referenced
this pull request
Oct 10, 2022
PR-URL: nodejs/node#43620 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: #43084 (comment)