Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add daeyeon to triagers #43637

Merged

Conversation

daeyeon
Copy link
Member

@daeyeon daeyeon commented Jun 30, 2022

I would like to join the Triagers team.

My motivation is to help manage issues, be more involved in Node.js, and eventually become a collaborator!

I hereby declare that I have read and understood Code of Conduct and will adhere to that.

Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Jun 30, 2022
@F3n67u
Copy link
Member

F3n67u commented Jun 30, 2022

Welcome, @daeyeon!

@daeyeon
Copy link
Member Author

daeyeon commented Jun 30, 2022

@F3n67u Thanks for welcoming!

Copy link
Member

@VoltrexKeyva VoltrexKeyva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome aboard!

Copy link
Contributor

@RaisinTen RaisinTen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, welcome Daeyeon! :-)

cc @nodejs/issue-triage

Copy link

@aroramrinaal aroramrinaal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good!

@F3n67u F3n67u added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 1, 2022
@lpinca lpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 4, 2022
@lpinca
Copy link
Member

lpinca commented Jul 4, 2022

@daeyeon can you click the "Request to join" button here https://github.com/orgs/nodejs/teams/issue-triage/members? I think @gireeshpunathil can add you to the team.

@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 4, 2022
@nodejs-github-bot nodejs-github-bot merged commit 9fa1100 into nodejs:main Jul 4, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in 9fa1100

@daeyeon
Copy link
Member Author

daeyeon commented Jul 4, 2022

Thank you, @lpinca, and thank you all!

@gireeshpunathil I'm not able to open the link yet. :-) Could you add me to the team?

@daeyeon daeyeon deleted the main.volunteer-220701.Fri.4213 branch July 4, 2022 13:44
@gireeshpunathil
Copy link
Member

@gireeshpunathil I'm not able to open the link yet. :-) Could you add me to the team?

invitation sent.

targos pushed a commit that referenced this pull request Jul 12, 2022
Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com

PR-URL: #43637
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Qingyu Deng <i@ayase-lab.com>
Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
targos pushed a commit that referenced this pull request Jul 20, 2022
Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com

PR-URL: #43637
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Qingyu Deng <i@ayase-lab.com>
Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
targos pushed a commit that referenced this pull request Jul 31, 2022
Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com

PR-URL: #43637
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Qingyu Deng <i@ayase-lab.com>
Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com

PR-URL: nodejs/node#43637
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Qingyu Deng <i@ayase-lab.com>
Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants