stream: finish pipeline if dst closes before src #43701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
|
@nodejs/streams @vweevers |
If the destination stream is closed before the source has completed the pipeline should finnish with premature close. Fixes: nodejs#43682
lpinca
approved these changes
Jul 6, 2022
ronag
added
request-ci
github-actions
bot
removed
the
request-ci
github-actions
bot
removed
the
request-ci
ronag
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
Commit Queue failed- Loading data for nodejs/node/pull/43701 ✔ Done loading data for nodejs/node/pull/43701 ----------------------------------- PR info ------------------------------------ Title stream: finish pipeline if dst closes before src (#43701) Author Robert Nagy (@ronag) Branch ronag:pipeline-finish -> nodejs:main Labels stream Commits 2 - stream: finish pipeline if dst closes before src - fixup Committers 1 - Robert Nagy PR-URL: https://github.com/nodejs/node/pull/43701 Fixes: https://github.com/nodejs/node/issues/43682 Reviewed-By: Matteo Collina Reviewed-By: Luigi Pinca ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/43701 Fixes: https://github.com/nodejs/node/issues/43682 Reviewed-By: Matteo Collina Reviewed-By: Luigi Pinca -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last review: ⚠ - fixup ℹ This PR was created on Wed, 06 Jul 2022 11:25:18 GMT ✔ Approvals: 2 ✔ - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/43701#pullrequestreview-1029932092 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/43701#pullrequestreview-1029938147 ✖ This PR needs to wait 27 more hours to land ✖ Last GitHub CI failed ✖ No Jenkins CI runs detected -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/2628008197 |
nodejs-github-bot
added
the
commit-queue-failed
20 tasks
mcollina
added
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/43701 ✔ Done loading data for nodejs/node/pull/43701 ----------------------------------- PR info ------------------------------------ Title stream: finish pipeline if dst closes before src (#43701) Author Robert Nagy (@ronag) Branch ronag:pipeline-finish -> nodejs:main Labels stream, commit-queue-squash Commits 2 - stream: finish pipeline if dst closes before src - fixup Committers 1 - Robert Nagy PR-URL: https://github.com/nodejs/node/pull/43701 Fixes: https://github.com/nodejs/node/issues/43682 Reviewed-By: Matteo Collina Reviewed-By: Luigi Pinca ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/43701 Fixes: https://github.com/nodejs/node/issues/43682 Reviewed-By: Matteo Collina Reviewed-By: Luigi Pinca -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last review: ⚠ - fixup ℹ This PR was created on Wed, 06 Jul 2022 11:25:18 GMT ✔ Approvals: 2 ✔ - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/43701#pullrequestreview-1029932092 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/43701#pullrequestreview-1029938147 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2022-07-10T18:43:08Z: https://ci.nodejs.org/job/node-test-pull-request/45277/ - Querying data for job/node-test-pull-request/45277/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/2648025585 |
|
@ronag I don't know why the commit bot is failing, you might want to land this manually. |
ronag
added
the
author ready
|
@mcollina it's failing because "Commits were pushed since the last review". |
mcollina
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in e4bf5dc |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the destination stream is closed before the source has completed
the pipeline should finnish with premature close.
Fixes: #43682