Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stream: only cleanup error listener if not readable #44304

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

stream: only cleanup error listener if not readable #44304

wants to merge 2 commits into from

Conversation

ronag
Copy link
Member

@ronag ronag commented Aug 20, 2022

Only cleanup the error listener if we know for sure that
the last stream is still readable after the pipeline has
completed.

@ronag
stream: only cleanup error listener if not readable
f90da17 
Only cleanup the error listener if we know for sure that
the last stream is still readable after the pipeline has
completed.
@ronag ronag added the stream Issues and PRs related to the stream subsystem. label Aug 20, 2022
@ronag ronag requested a review from mcollina August 20, 2022 10:59
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Aug 20, 2022 •
edited by ronag

Review requested:

  • @nodejs/streams

@ronag
Copy link
Member Author

ronag commented Aug 20, 2022

@nodejs/streams

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Aug 20, 2022
@ronag ronag added request-ci Add this label to start a Jenkins CI on a PR. and removed needs-ci PRs that need a full CI run. labels Aug 20, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 20, 2022
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/46086/

@github-actions github-actions bot mentioned this pull request Aug 21, 2022
Open
16 tasks
@ronag ronag added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 21, 2022
@ronag ronag requested a review from lpinca August 21, 2022 11:05
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 21, 2022
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/46113/

@ronag ronag added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 21, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 21, 2022
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/46115/

@ronag ronag marked this pull request as draft August 21, 2022 14:06
@github-actions github-actions bot mentioned this pull request Aug 22, 2022
Open
36 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina Awaiting requested review from mcollina

@lpinca lpinca Awaiting requested review from lpinca

Assignees
No one assigned
Labels
stream Issues and PRs related to the stream subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ronag @nodejs-github-bot