src: avoid crash using uv.errname() binding
#44401
Closed
+18
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
Return undefined from uv binding when no args are provided and do the libuv call with any arg (if provided) to the binding. Fixes: nodejs#44400
juanarbol
force-pushed
the
juan/fix-uv-crash
branch
from
d29f823
to
5a6c520
Compare
juanarbol
added
the
fast-track
|
Fast-track has been requested by @juanarbol. Please 👍 to approve. |
|
Do we need to check |
Nope, that's why I removed that assertion and return |
RaisinTen
reviewed
Aug 26, 2022
RaisinTen
suggested changes
Aug 26, 2022
There was a problem hiding this comment.
The added test is failing on asan builds because of a memory leak from https://github.com/libuv/libuv/blob/fb76f210eb6f093bc06a2f07646e56851818ccf2/src/uv-common.c#L170.
juanarbol
removed
the
fast-track
4 tasks
legendecas
reviewed
Aug 28, 2022
|
I will close this; at this moment, it does not make any sense in the runtime, and #44421 made something better <3 |
Fyko
pushed a commit
to Fyko/node
that referenced
this pull request
Sep 15, 2022
PR-URL: nodejs#44421 Refs: nodejs#44401 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
guangwong
pushed a commit
to noslate-project/node
that referenced
this pull request
Jan 3, 2023
PR-URL: nodejs/node#44421 Refs: nodejs/node#44401 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
guangwong
pushed a commit
to noslate-project/node
that referenced
this pull request
Jan 3, 2023
PR-URL: nodejs/node#44421 Refs: nodejs/node#44401 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Return undefined from uv binding when no args are provided and do the libuv
call with any arg (if provided) to the binding.
Fixes: #44400
This crash is being provoked by this assertion, using the binding directly is not guarantee that it will be invoked with the expected signature.