crypto: don't claim errors come from within OpenSSL #44560
+6
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to OpenSSL 3.0, OpenSSL's error system maintained numeric function codes for what function the error came from, which caused a number of problems. OpenSSL 3.0 has dropped these (the function code parameter is ignored). But even in OpenSSL 1.1.1, specifying them in Node doesn't make sense. The errors don't come from the functions Node is claiming they do.
|
Review requested:
|
nodejs-github-bot
added
c++
github-actions
bot
removed
the
request-ci
This was referenced Sep 11, 2022
|
Friendly ping. Is this waiting on anything from my end? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to OpenSSL 3.0, OpenSSL's error system maintained numeric function codes for what function the error came from, which caused a number of problems. OpenSSL 3.0 has dropped these (the function code parameter is ignored). But even in OpenSSL 1.1.1, specifying them in Node doesn't make sense. The errors don't come from the functions Node is claiming they do.