Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: change promises to async/await in test-debugger-heap-profiler #44693

Merged
merged 1 commit into from Sep 29, 2022

Conversation

brindashar4
Copy link
Contributor

No description provided.

@Trott Trott added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Sep 16, 2022
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Sep 16, 2022
Copy link
Member

@Qard Qard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Just some small suggestions to make the linter happy. 😊

test/sequential/test-debugger-heap-profiler.js Outdated Show resolved Hide resolved
test/sequential/test-debugger-heap-profiler.js Outdated Show resolved Hide resolved
Trott
Trott approved these changes Sep 25, 2022
@Trott Trott added request-ci Add this label to start a Jenkins CI on a PR. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Sep 25, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 25, 2022
@nodejs-github-bot
Copy link
Contributor

@nodejs-github-bot
Copy link
Contributor

@nodejs-github-bot
Copy link
Contributor

@nodejs-github-bot
Copy link
Contributor

@nodejs-github-bot
Copy link
Contributor

@Trott Trott added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 29, 2022
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Sep 29, 2022
@nodejs-github-bot
Copy link
Contributor

Commit Queue failed
- Loading data for nodejs/node/pull/44693
✔  Done loading data for nodejs/node/pull/44693
----------------------------------- PR info ------------------------------------
Title      test: change promises to async/await in test-debugger-heap-profiler (#44693)
Author     Brinda Ashar  (@brindashar4, first-time contributor)
Branch     brindashar4:brinda-patch-test -> nodejs:main
Labels     test, code-and-learn, author ready, needs-ci
Commits    1
 - test: use async/await in test-debugger-heap-profiler
Committers 1
 - Rich Trott 
PR-URL: https://github.com/nodejs/node/pull/44693
Reviewed-By: Rich Trott 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/44693
Reviewed-By: Rich Trott 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Fri, 16 Sep 2022 21:58:29 GMT
   ✔  Approvals: 1
   ✔  - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/44693#pullrequestreview-1119430727
   ℹ  This PR is being fast-tracked because it is from a Code and Learn event
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2022-09-29T06:27:04Z: https://ci.nodejs.org/job/node-test-pull-request/46919/
- Querying data for job/node-test-pull-request/46919/
   ✔  Last Jenkins CI successful
   ⚠  PR author is a new contributor: @brindashar4(brindashar4@gmail.com)
   ⚠  - commit 3f61a3e1fabd is authored by brindaas@buffalo.edu
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/3152126664

PR-URL: nodejs#44693
Reviewed-By: Rich Trott <rtrott@gmail.com>
@Trott
Copy link
Member

Trott commented Sep 29, 2022

Landed in 865a578

@Trott Trott merged commit 865a578 into nodejs:main Sep 29, 2022
18 checks passed
@Trott
Copy link
Member

Trott commented Sep 29, 2022

Thanks for the contribution! 🎉

danielleadams pushed a commit that referenced this pull request Oct 11, 2022
PR-URL: #44693
Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. commit-queue-failed An error occurred while landing this pull request using GitHub Actions. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants