Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: update node prefix require.cache example #44724

Merged
merged 1 commit into from Oct 2, 2022

Conversation

simoneb
Copy link
Contributor

@simoneb simoneb commented Sep 19, 2022

I think it would be more intuitive if the docs showed passing assertions

@nodejs-github-bot
Copy link
Contributor

Review requested:

  • @nodejs/modules

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. module Issues and PRs related to the module subsystem. labels Sep 19, 2022
lpinca
lpinca approved these changes Sep 19, 2022
Copy link
Member

@RaisinTen RaisinTen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: using fix instead of update in the title sounds more appropriate IMO because the previous code is incorrect as it runs into an assertion error

@daeyeon daeyeon added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Sep 23, 2022
jasnell
jasnell approved these changes Oct 2, 2022
@jasnell jasnell added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 2, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 2, 2022
@nodejs-github-bot nodejs-github-bot merged commit 8f16a8c into nodejs:main Oct 2, 2022
22 checks passed
@nodejs-github-bot
Copy link
Contributor

Landed in 8f16a8c

danielleadams pushed a commit that referenced this pull request Oct 11, 2022
PR-URL: #44724
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. module Issues and PRs related to the module subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants