Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: check --test is disallowed in NODE_OPTIONS #44846

Merged

Conversation

cola119
Copy link
Member

@cola119 cola119 commented Oct 1, 2022

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Oct 1, 2022
@panva panva added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 1, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 1, 2022
@nodejs-github-bot
Copy link
Contributor

cjihrig
cjihrig approved these changes Oct 1, 2022
lpinca
lpinca approved these changes Oct 1, 2022
daeyeon
daeyeon approved these changes Oct 2, 2022
@daeyeon daeyeon added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 2, 2022
bnb
bnb approved these changes Oct 2, 2022
jasnell
jasnell approved these changes Oct 2, 2022
@nodejs-github-bot
Copy link
Contributor

@cola119 cola119 added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 7, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 7, 2022
@nodejs-github-bot nodejs-github-bot merged commit 2c57b94 into nodejs:main Oct 7, 2022
57 checks passed
@nodejs-github-bot
Copy link
Contributor

Landed in 2c57b94

danielleadams pushed a commit that referenced this pull request Oct 11, 2022
PR-URL: #44846
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Tierney Cyren <hello@bnb.im>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants