Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: remove unnecessary leading commas #44854

Merged
merged 1 commit into from Oct 4, 2022
Merged

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Oct 1, 2022

There are several locations in the test_runner API docs where the optional first argument to a function was written with a leading comma. Since these are first arguments, the commas can be removed.

There are several locations in the test_runner API docs where
the optional first argument to a function was written with a
leading comma. Since these are first arguments, the commas
can be removed.
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. test Issues and PRs related to the tests. labels Oct 1, 2022
Trott
Trott approved these changes Oct 2, 2022
daeyeon
daeyeon approved these changes Oct 2, 2022
lpinca
lpinca approved these changes Oct 2, 2022
@MoLow MoLow added dont-land-on-v14.x PRs that should not land on the v14.x-staging branch and should not be released in v14.x. test_runner labels Oct 2, 2022
MoLow
MoLow approved these changes Oct 2, 2022
@MoLow MoLow removed the test Issues and PRs related to the tests. label Oct 2, 2022
jasnell
jasnell approved these changes Oct 2, 2022
@cjihrig cjihrig added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 4, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 4, 2022
@nodejs-github-bot nodejs-github-bot merged commit 417458d into main Oct 4, 2022
24 checks passed
@nodejs-github-bot
Copy link
Contributor

Landed in 417458d

@nodejs-github-bot nodejs-github-bot deleted the cjihrig-patch-2 branch October 4, 2022 01:56
panva pushed a commit to panva/node that referenced this pull request Oct 4, 2022
There are several locations in the test_runner API docs where
the optional first argument to a function was written with a
leading comma. Since these are first arguments, the commas
can be removed.

PR-URL: nodejs#44854
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams pushed a commit that referenced this pull request Oct 11, 2022
There are several locations in the test_runner API docs where
the optional first argument to a function was written with a
leading comma. Since these are first arguments, the commas
can be removed.

PR-URL: #44854
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MoLow pushed a commit to MoLow/node that referenced this pull request Nov 23, 2022
There are several locations in the test_runner API docs where
the optional first argument to a function was written with a
leading comma. Since these are first arguments, the commas
can be removed.

PR-URL: nodejs#44854
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MoLow pushed a commit to MoLow/node that referenced this pull request Dec 9, 2022
There are several locations in the test_runner API docs where
the optional first argument to a function was written with a
leading comma. Since these are first arguments, the commas
can be removed.

PR-URL: nodejs#44854
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. dont-land-on-v14.x PRs that should not land on the v14.x-staging branch and should not be released in v14.x. test_runner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants