Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: move release keys we don't use anymore in README #44899

Merged
merged 2 commits into from Oct 7, 2022

Conversation

@Trott
Copy link
Member Author

Trott commented Oct 6, 2022

@nodejs/releasers

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Oct 6, 2022
@Trott Trott added fast-track PRs that do not need to wait for 48 hours to land. and removed doc Issues and PRs related to the documentations. labels Oct 6, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2022

Fast-track has been requested by @Trott. Please 👍 to approve.

targos
targos approved these changes Oct 6, 2022
lpinca
lpinca approved these changes Oct 6, 2022
@Trott Trott added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 6, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 6, 2022
@nodejs-github-bot
Copy link
Contributor

Commit Queue failed
- Loading data for nodejs/node/pull/44899
✔  Done loading data for nodejs/node/pull/44899
----------------------------------- PR info ------------------------------------
Title      doc: move release keys we don't use anymore in README (#44899)
Author     Rich Trott  (@Trott)
Branch     Trott:releasers -> nodejs:main
Labels     fast-track
Commits    2
 - doc: move release keys we don't use anymore in README
 - fixup! doc: move release keys we don't use anymore in README
Committers 1
 - Rich Trott 
PR-URL: https://github.com/nodejs/node/pull/44899
Refs: https://github.com/nodejs/Release/blob/3cd3c6a65188d0e64017d0cee11b9834a5753fd5/GOVERNANCE.md#offboarding-releasers
Refs: https://github.com/nodejs/Release/pull/784
Reviewed-By: Richard Lau 
Reviewed-By: Michaël Zasso 
Reviewed-By: Luigi Pinca 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/44899
Refs: https://github.com/nodejs/Release/blob/3cd3c6a65188d0e64017d0cee11b9834a5753fd5/GOVERNANCE.md#offboarding-releasers
Refs: https://github.com/nodejs/Release/pull/784
Reviewed-By: Richard Lau 
Reviewed-By: Michaël Zasso 
Reviewed-By: Luigi Pinca 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Thu, 06 Oct 2022 00:23:20 GMT
   ✔  Approvals: 3
   ✔  - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/44899#pullrequestreview-1132195873
   ✔  - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/44899#pullrequestreview-1133136782
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/44899#pullrequestreview-1133500155
   ℹ  This PR is being fast-tracked
   ✖  The fast-track request requires at least two collaborators' approvals (👍).
   ✔  Last GitHub CI successful
   ℹ  Green GitHub CI is sufficient
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/3200609475

@nodejs-github-bot nodejs-github-bot added the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Oct 6, 2022
@Trott Trott added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Oct 6, 2022
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Oct 6, 2022
@nodejs-github-bot
Copy link
Contributor

Commit Queue failed
- Loading data for nodejs/node/pull/44899
✔  Done loading data for nodejs/node/pull/44899
----------------------------------- PR info ------------------------------------
Title      doc: move release keys we don't use anymore in README (#44899)
Author     Rich Trott  (@Trott)
Branch     Trott:releasers -> nodejs:main
Labels     fast-track, commit-queue-squash
Commits    2
 - doc: move release keys we don't use anymore in README
 - fixup! doc: move release keys we don't use anymore in README
Committers 1
 - Rich Trott 
PR-URL: https://github.com/nodejs/node/pull/44899
Refs: https://github.com/nodejs/Release/blob/3cd3c6a65188d0e64017d0cee11b9834a5753fd5/GOVERNANCE.md#offboarding-releasers
Refs: https://github.com/nodejs/Release/pull/784
Reviewed-By: Richard Lau 
Reviewed-By: Michaël Zasso 
Reviewed-By: Luigi Pinca 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/44899
Refs: https://github.com/nodejs/Release/blob/3cd3c6a65188d0e64017d0cee11b9834a5753fd5/GOVERNANCE.md#offboarding-releasers
Refs: https://github.com/nodejs/Release/pull/784
Reviewed-By: Richard Lau 
Reviewed-By: Michaël Zasso 
Reviewed-By: Luigi Pinca 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Thu, 06 Oct 2022 00:23:20 GMT
   ✔  Approvals: 3
   ✔  - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/44899#pullrequestreview-1132195873
   ✔  - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/44899#pullrequestreview-1133136782
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/44899#pullrequestreview-1133500155
   ℹ  This PR is being fast-tracked
   ✖  The fast-track request requires at least two collaborators' approvals (👍).
   ✔  Last GitHub CI successful
   ℹ  Green GitHub CI is sufficient
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/3200661575

@Trott Trott removed the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Oct 6, 2022
@Trott Trott added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 7, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 7, 2022
@nodejs-github-bot nodejs-github-bot merged commit 24d255f into nodejs:main Oct 7, 2022
23 checks passed
@nodejs-github-bot
Copy link
Contributor

Landed in 24d255f

@Trott Trott deleted the releasers branch Oct 7, 2022
danielleadams pushed a commit that referenced this pull request Oct 11, 2022
Refs: https://github.com/nodejs/Release/blob/3cd3c6a65188d0e64017d0cee11b9834a5753fd5/GOVERNANCE.md#offboarding-releasers
Refs: nodejs/Release#784
PR-URL: #44899
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants