Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: skip test-fs-largefile if not enough disk space #45339

Merged
merged 1 commit into from
Nov 7, 2022

Conversation

Trott
Copy link
Member

@Trott Trott commented Nov 6, 2022

Fixes: nodejs/build#3071

I'm guessing this is the test that then causes other cascading disk failures, but maybe there are others. Let's run CI here and find out....

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Nov 6, 2022
@Trott Trott added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 6, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 6, 2022
@nodejs-github-bot
Copy link
Collaborator

@Trott
Copy link
Member Author

Trott commented Nov 6, 2022

My Jenkins CI didn't run out of space so I'm running just the macOS part of it again. I want to see that the test is actually skipped when ENOSPC happens. https://ci.nodejs.org/job/node-test-commit-osx/48467/

EDIT: And another one. https://ci.nodejs.org/job/node-test-commit-osx/48469/

EDIT: And one more. https://ci.nodejs.org/job/node-test-commit-osx/48470/

@Trott
Copy link
Member Author

Trott commented Nov 7, 2022

Here's another one: https://ci.nodejs.org/job/node-test-commit-osx/48483/

@nodejs-github-bot
Copy link
Collaborator

@Trott
Copy link
Member Author

Trott commented Nov 7, 2022

Hooray, it caught a failure that time!

https://ci.nodejs.org/job/node-test-commit-osx/48483/nodes=osx1015/console

image

I think this is ready for review and landing.

@anonrig @nodejs/testing

Copy link
Member

@anonrig anonrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! Thanks @Trott. Can you apply the same changes to other tests too?

@anonrig anonrig added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 7, 2022
@anonrig anonrig added the fast-track PRs that do not need to wait for 48 hours to land. label Nov 7, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Nov 7, 2022

Fast-track has been requested by @anonrig. Please 👍 to approve.

@anonrig anonrig added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 7, 2022
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Nov 7, 2022
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/45339
✔  Done loading data for nodejs/node/pull/45339
----------------------------------- PR info ------------------------------------
Title      test: skip test-fs-largefile if not enough disk space (#45339)
Author     Rich Trott  (@Trott)
Branch     Trott:fix-fs -> nodejs:main
Labels     test, fast-track, author ready, needs-ci
Commits    1
 - test: skip test-fs-largefile if not enough disk space
Committers 1
 - Rich Trott 
PR-URL: https://github.com/nodejs/node/pull/45339
Fixes: https://github.com/nodejs/build/issues/3071
Reviewed-By: Yagiz Nizipli 
Reviewed-By: Nitzan Uziely 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/45339
Fixes: https://github.com/nodejs/build/issues/3071
Reviewed-By: Yagiz Nizipli 
Reviewed-By: Nitzan Uziely 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Sun, 06 Nov 2022 15:55:11 GMT
   ✔  Approvals: 2
   ✔  - Yagiz Nizipli (@anonrig): https://github.com/nodejs/node/pull/45339#pullrequestreview-1169721564
   ✔  - Nitzan Uziely (@linkgoron): https://github.com/nodejs/node/pull/45339#pullrequestreview-1169894956
   ℹ  This PR is being fast-tracked
   ✖  The fast-track request requires at least one collaborator's approval (👍).
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2022-11-07T00:01:32Z: https://ci.nodejs.org/job/node-test-pull-request/47751/
- Querying data for job/node-test-pull-request/47751/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/3412750367

@Trott Trott added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Nov 7, 2022
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Nov 7, 2022
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/45339
✔  Done loading data for nodejs/node/pull/45339
----------------------------------- PR info ------------------------------------
Title      test: skip test-fs-largefile if not enough disk space (#45339)
Author     Rich Trott  (@Trott)
Branch     Trott:fix-fs -> nodejs:main
Labels     test, fast-track, author ready, needs-ci
Commits    1
 - test: skip test-fs-largefile if not enough disk space
Committers 1
 - Rich Trott 
PR-URL: https://github.com/nodejs/node/pull/45339
Fixes: https://github.com/nodejs/build/issues/3071
Reviewed-By: Yagiz Nizipli 
Reviewed-By: Nitzan Uziely 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/45339
Fixes: https://github.com/nodejs/build/issues/3071
Reviewed-By: Yagiz Nizipli 
Reviewed-By: Nitzan Uziely 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Sun, 06 Nov 2022 15:55:11 GMT
   ✔  Approvals: 2
   ✔  - Yagiz Nizipli (@anonrig): https://github.com/nodejs/node/pull/45339#pullrequestreview-1169721564
   ✔  - Nitzan Uziely (@linkgoron): https://github.com/nodejs/node/pull/45339#pullrequestreview-1169894956
   ℹ  This PR is being fast-tracked
   ✖  The fast-track request requires at least one collaborator's approval (👍).
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2022-11-07T17:54:35Z: https://ci.nodejs.org/job/node-test-pull-request/47751/
- Querying data for job/node-test-pull-request/47751/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/3412750367

Fixes: nodejs/build#3071

PR-URL: nodejs#45339
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Nitzan Uziely <linkgoron@gmail.com>
@Trott
Copy link
Member Author

Trott commented Nov 7, 2022

Landed in e080331

@Trott Trott deleted the fix-fs branch November 7, 2022 19:13
lucshi pushed a commit to lucshi/node that referenced this pull request Nov 9, 2022
Fixes: nodejs/build#3071

PR-URL: nodejs#45339
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Nitzan Uziely <linkgoron@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Nov 10, 2022
Fixes: nodejs/build#3071

PR-URL: #45339
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Nitzan Uziely <linkgoron@gmail.com>
@RafaelGSS RafaelGSS mentioned this pull request Nov 10, 2022
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
Fixes: nodejs/build#3071

PR-URL: #45339
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Nitzan Uziely <linkgoron@gmail.com>
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
Fixes: nodejs/build#3071

PR-URL: #45339
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Nitzan Uziely <linkgoron@gmail.com>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
Fixes: nodejs/build#3071

PR-URL: #45339
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Nitzan Uziely <linkgoron@gmail.com>
danielleadams pushed a commit that referenced this pull request Jan 4, 2023
Fixes: nodejs/build#3071

PR-URL: #45339
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Nitzan Uziely <linkgoron@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-failed An error occurred while landing this pull request using GitHub Actions. fast-track PRs that do not need to wait for 48 hours to land. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No space left on device OSX 1015
4 participants