Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

benchmark: add benchmark for EventTarget add and remove #46779

Merged
merged 1 commit into from
Feb 26, 2023
Merged

benchmark: add benchmark for EventTarget add and remove #46779

merged 1 commit into from
Feb 26, 2023

Conversation

debadree25
Copy link
Member

Added a simple benchmark similar to benchmark/events/ee-add-remove.js

Refs: nodejs/performance#60

@nodejs-github-bot nodejs-github-bot added benchmark Issues and PRs related to the benchmark subsystem. events Issues and PRs related to the events subsystem / EventEmitter. labels Feb 22, 2023
@debadree25 debadree25 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 23, 2023
@debadree25 debadree25 added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 25, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 25, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49998/

@debadree25 debadree25 added the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 26, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 26, 2023
@nodejs-github-bot nodejs-github-bot merged commit 80a7843 into nodejs:main Feb 26, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in 80a7843

targos pushed a commit that referenced this pull request Mar 13, 2023
@debadree25 @targos
benchmark: add benchmark for EventTarget add and remove
171b2a8 
Refs: nodejs/performance#60
PR-URL: #46779
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Mar 14, 2023
@debadree25 @targos
benchmark: add benchmark for EventTarget add and remove
760a351 
Refs: nodejs/performance#60
PR-URL: #46779
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos targos mentioned this pull request Mar 14, 2023
Merged
danielleadams pushed a commit that referenced this pull request Apr 11, 2023
@debadree25 @danielleadams
benchmark: add benchmark for EventTarget add and remove
5f647fb 
Refs: nodejs/performance#60
PR-URL: #46779
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@danielleadams danielleadams mentioned this pull request Apr 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@benjamingr benjamingr benjamingr approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. benchmark Issues and PRs related to the benchmark subsystem. events Issues and PRs related to the events subsystem / EventEmitter.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@debadree25 @nodejs-github-bot @jasnell @benjamingr