test_runner: remove root tracking set #46961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
dont-land-on-v14.x
needs-ci
ljharb
reviewed
Mar 5, 2023
| @@ -105,7 +103,7 @@ function collectCoverage(rootTest, coverage) { | |||
| } | |||
|
|
|||
| function setup(root) { | |||
| if (wasRootSetup.has(root)) { | |||
| if (root.startTime !== null) { | |||
There was a problem hiding this comment.
Doesn’t this change mean that someone could create a Test themselves, and be able to monkey with the harness? By using a weakest you’re ensuring that only things you create are treated as such.
There was a problem hiding this comment.
I don't think userland has access to any of the necessary APIs (the Test class or any of the harness internals) to do that.
MoLow
approved these changes
Mar 5, 2023
ljharb
approved these changes
Mar 5, 2023
github-actions
bot
removed
the
request-ci
20 tasks
anonrig
approved these changes
Mar 6, 2023
cjihrig
added
author ready
19 tasks
The wasRootSetup Set in the test harness appears to be redundant, since the startTime field can be used interchangeably. This commit removes wasRootSetup. PR-URL: nodejs#46961 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
This was referenced Mar 8, 2023
targos
pushed a commit
that referenced
this pull request
Mar 13, 2023
The wasRootSetup Set in the test harness appears to be redundant, since the startTime field can be used interchangeably. This commit removes wasRootSetup. PR-URL: #46961 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
targos
pushed a commit
that referenced
this pull request
Mar 14, 2023
The wasRootSetup Set in the test harness appears to be redundant, since the startTime field can be used interchangeably. This commit removes wasRootSetup. PR-URL: #46961 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
danielleadams
pushed a commit
that referenced
this pull request
Apr 11, 2023
The wasRootSetup Set in the test harness appears to be redundant, since the startTime field can be used interchangeably. This commit removes wasRootSetup. PR-URL: #46961 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
wasRootSetupSetin the test harness appears to be redundant, since thestartTimefield can be used interchangeably. This commit removeswasRootSetup.