Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: disable Codecov commit statuses #47306

Merged
merged 1 commit into from Apr 1, 2023
Merged

tools: disable Codecov commit statuses #47306

merged 1 commit into from Apr 1, 2023

Conversation

targos
Copy link
Member

@targos targos commented Mar 30, 2023

We don't want (yet?) to consider coverage as a requirement for landing a pull request.

Refs: #47285 (comment)
Refs: https://docs.codecov.com/docs/commit-status#disabling-a-status

@targos
tools: disable Codecov commit statuses
28b694e 
We don't want (yet?) to consider coverage as a requirement for
landing a pull request.

Refs: nodejs#47285 (comment)
Refs: https://docs.codecov.com/docs/commit-status#disabling-a-status
@panva panva added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 30, 2023
@panva panva added the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 30, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 1, 2023
@nodejs-github-bot nodejs-github-bot merged commit d918bf4 into nodejs:main Apr 1, 2023
28 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in d918bf4

@targos targos deleted the codecov-status branch April 1, 2023 07:10
@RafaelGSS RafaelGSS mentioned this pull request Apr 3, 2023
Merged
RafaelGSS pushed a commit that referenced this pull request Apr 5, 2023
@targos @RafaelGSS
tools: disable Codecov commit statuses
39b0740 
We don't want (yet?) to consider coverage as a requirement for
landing a pull request.

Refs: #47285 (comment)
Refs: https://docs.codecov.com/docs/commit-status#disabling-a-status
PR-URL: #47306
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Apr 5, 2023
@targos @RafaelGSS
tools: disable Codecov commit statuses
53f3eed 
We don't want (yet?) to consider coverage as a requirement for
landing a pull request.

Refs: #47285 (comment)
Refs: https://docs.codecov.com/docs/commit-status#disabling-a-status
PR-URL: #47306
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@RafaelGSS RafaelGSS mentioned this pull request Apr 6, 2023
Merged
RafaelGSS pushed a commit that referenced this pull request Apr 6, 2023
@targos @RafaelGSS
tools: disable Codecov commit statuses
5bcf0e8 
We don't want (yet?) to consider coverage as a requirement for
landing a pull request.

Refs: #47285 (comment)
Refs: https://docs.codecov.com/docs/commit-status#disabling-a-status
PR-URL: #47306
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Apr 7, 2023
@targos @RafaelGSS
tools: disable Codecov commit statuses
af98218 
We don't want (yet?) to consider coverage as a requirement for
landing a pull request.

Refs: #47285 (comment)
Refs: https://docs.codecov.com/docs/commit-status#disabling-a-status
PR-URL: #47306
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Apr 8, 2023
@targos @RafaelGSS
tools: disable Codecov commit statuses
c340de6 
We don't want (yet?) to consider coverage as a requirement for
landing a pull request.

Refs: #47285 (comment)
Refs: https://docs.codecov.com/docs/commit-status#disabling-a-status
PR-URL: #47306
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
@targos @danielleadams
tools: disable Codecov commit statuses
397992e 
We don't want (yet?) to consider coverage as a requirement for
landing a pull request.

Refs: #47285 (comment)
Refs: https://docs.codecov.com/docs/commit-status#disabling-a-status
PR-URL: #47306
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MoLow pushed a commit to MoLow/node that referenced this pull request Jul 6, 2023
@targos @MoLow
tools: disable Codecov commit statuses
e1846ee 
We don't want (yet?) to consider coverage as a requirement for
landing a pull request.

Refs: nodejs#47285 (comment)
Refs: https://docs.codecov.com/docs/commit-status#disabling-a-status
PR-URL: nodejs#47306
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@danielleadams danielleadams mentioned this pull request Jul 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@panva panva panva approved these changes

@jasnell jasnell jasnell approved these changes

@Trott Trott Trott approved these changes

@lpinca lpinca lpinca approved these changes

@cjihrig cjihrig cjihrig approved these changes

@gengjiawen gengjiawen gengjiawen approved these changes

@richardlau richardlau richardlau approved these changes

@MoLow MoLow MoLow approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
10 participants
@targos @nodejs-github-bot @panva @jasnell @Trott @lpinca @cjihrig @gengjiawen @richardlau @MoLow