Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

blob: fix range error with many chunks #47320

Merged
merged 1 commit into from Apr 1, 2023
Merged

blob: fix range error with many chunks #47320

merged 1 commit into from Apr 1, 2023

Conversation

KhafraDev
Copy link
Member

Fixes #47301

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Mar 30, 2023
@jasnell
Copy link
Member

jasnell commented Mar 30, 2023

Thank you!

@anonrig anonrig added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Mar 30, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 30, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50709/

@anonrig anonrig added the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 30, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 1, 2023
@nodejs-github-bot nodejs-github-bot merged commit 85705a4 into nodejs:main Apr 1, 2023
58 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 85705a4

@KhafraDev KhafraDev deleted the blob-range-error branch April 1, 2023 14:53
@RafaelGSS RafaelGSS mentioned this pull request Apr 3, 2023
Merged
RafaelGSS pushed a commit that referenced this pull request Apr 5, 2023
@KhafraDev @RafaelGSS
buffer: fix blob range error with many chunks
c6b02de 
PR-URL: #47320
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Apr 5, 2023
@KhafraDev @RafaelGSS
buffer: fix blob range error with many chunks
d149a45 
PR-URL: #47320
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
@RafaelGSS RafaelGSS mentioned this pull request Apr 6, 2023
Merged
RafaelGSS pushed a commit that referenced this pull request Apr 6, 2023
@KhafraDev @RafaelGSS
buffer: fix blob range error with many chunks
6e497d4 
PR-URL: #47320
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Apr 7, 2023
@KhafraDev @RafaelGSS
buffer: fix blob range error with many chunks
3f0061c 
PR-URL: #47320
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
@travis travis mentioned this pull request Apr 7, 2023
Closed
RafaelGSS pushed a commit that referenced this pull request Apr 8, 2023
@KhafraDev @RafaelGSS
buffer: fix blob range error with many chunks
23a69d9 
PR-URL: #47320
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
@danielleadams danielleadams added the dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. label Jun 12, 2023
@rluvaton rluvaton mentioned this pull request Sep 26, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@anonrig anonrig anonrig approved these changes

@VoltrexKeyva VoltrexKeyva VoltrexKeyva approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Blob regression in v19.8.x
6 participants
@KhafraDev @jasnell @nodejs-github-bot @anonrig @VoltrexKeyva @danielleadams