Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: port flaky wpt/html/webappapis/timers tests to test/sequential #47657

Closed
wants to merge 1 commit into from
Closed

test: port flaky wpt/html/webappapis/timers tests to test/sequential #47657

wants to merge 1 commit into from

Conversation

panva
Copy link
Member

@panva panva commented Apr 21, 2023 •
edited

wpt/test-timers has been unreliable since we've re-enabled parallel execution in WPTs. This PR removes the html/webappapis/timers WPTs and ports the tests to test/sequential instead.

e.g.
nodejs/reliability#548
image

@panva panva added timers Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout. test Issues and PRs related to the tests. labels Apr 21, 2023
@panva panva mentioned this pull request Apr 21, 2023
Merged
@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Apr 21, 2023
@panva
Copy link
Member Author

panva commented Apr 21, 2023

cc @nodejs/timers

@panva panva added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 21, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 21, 2023
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51399/

@panva panva added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 22, 2023
This was referenced Apr 24, 2023
Open
Open
@tniessen
Copy link
Member

I understand the motivation, but is there an alternative, such as adding an option to run some WPTs sequentially or so?

@github-actions github-actions bot mentioned this pull request Apr 26, 2023
Open
36 tasks
@panva
Copy link
Member Author

panva commented Apr 26, 2023

I understand the motivation, but is there an alternative, such as adding an option to run some WPTs sequentially or so?

Not when the other WPT suites execute in parallel. The problem appears to be in used up resources, and with webcrypto hogging those up...

@panva panva added the review wanted PRs that need reviews. label Apr 26, 2023
@github-actions github-actions bot mentioned this pull request Apr 27, 2023
Open
35 tasks
@panva panva added the flaky-test Issues and PRs related to the tests with unstable failures on the CI. label Apr 27, 2023
@panva
Copy link
Member Author

panva commented May 3, 2023

ping @nodejs/timers

@targos
Copy link
Member

targos commented May 3, 2023

Not when the other WPT suites execute in parallel. The problem appears to be in used up resources, and with webcrypto hogging those up...

If we're already parallelizing WPT suites in the WPT runner, shouldn't we run test/wpt sequentially?

@panva
Copy link
Member Author

panva commented May 3, 2023

Not when the other WPT suites execute in parallel. The problem appears to be in used up resources, and with webcrypto hogging those up...

If we're already parallelizing WPT suites in the WPT runner, shouldn't we run test/wpt sequentially?

I'm just looking at nodejs/reliability and wpt/test-webcrypto also occasionally crashes. So i'm going to open a PR reverting the python side of things to sequential and also introducing maximum parallelism option in the WPTRunner.

@panva panva mentioned this pull request May 3, 2023
Merged
@panva
Copy link
Member Author

panva commented May 3, 2023

Closing in favour of #47834

@panva panva closed this May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anonrig anonrig anonrig approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. flaky-test Issues and PRs related to the tests with unstable failures on the CI. needs-ci PRs that need a full CI run. review wanted PRs that need reviews. test Issues and PRs related to the tests. timers Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@panva @nodejs-github-bot @tniessen @targos @anonrig