test_runner: omit inaccessible files from coverage #47850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If V8 generates code coverage for a file that is later inaccessible to the test runner, then omit that file from the coverage report.
|
Review requested:
|
MoLow
approved these changes
May 4, 2023
MoLow
added
the
author ready
BethGriggs
approved these changes
May 10, 2023
cjihrig
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 4360389 |
nodejs-github-bot
added
the
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/47850 ✔ Done loading data for nodejs/node/pull/47850 ----------------------------------- PR info ------------------------------------ Title test_runner: omit inaccessible files from coverage (#47850) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch cjihrig:coverage-deleted -> nodejs:main Labels author ready, test_runner Commits 1 - test_runner: omit inaccessible files from coverage Committers 1 - cjihrig PR-URL: https://github.com/nodejs/node/pull/47850 Reviewed-By: Moshe Atlow Reviewed-By: Beth Griggs ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/47850 Reviewed-By: Moshe Atlow Reviewed-By: Beth Griggs -------------------------------------------------------------------------------- ℹ This PR was created on Thu, 04 May 2023 04:39:36 GMT ✔ Approvals: 2 ✔ - Moshe Atlow (@MoLow) (TSC): https://github.com/nodejs/node/pull/47850#pullrequestreview-1412281965 ✔ - Beth Griggs (@BethGriggs) (TSC): https://github.com/nodejs/node/pull/47850#pullrequestreview-1420721623 ⚠ This PR was merged on Wed, 10 May 2023 14:08:00 GMT ✔ Last GitHub CI successful ℹ Last Full PR CI on 2023-05-04T20:59:51Z: https://ci.nodejs.org/job/node-test-pull-request/51639/ - Querying data for job/node-test-pull-request/51639/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/4937826311 |
MoLow
removed
the
commit-queue-failed
targos
pushed a commit
that referenced
this pull request
May 12, 2023
If V8 generates code coverage for a file that is later inaccessible to the test runner, then omit that file from the coverage report. PR-URL: #47850 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Jul 6, 2023
If V8 generates code coverage for a file that is later inaccessible to the test runner, then omit that file from the coverage report. PR-URL: #47850 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com>
MoLow
pushed a commit
to MoLow/node
that referenced
this pull request
Jul 6, 2023
If V8 generates code coverage for a file that is later inaccessible to the test runner, then omit that file from the coverage report. PR-URL: nodejs#47850 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If V8 generates code coverage for a file that is later inaccessible to the test runner, then omit that file from the coverage report.