Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: add debug logs to deps update #48060

Merged
merged 1 commit into from May 22, 2023
Merged

tools: add debug logs to deps update #48060

merged 1 commit into from May 22, 2023

Conversation

marco-ippolito
Copy link
Member

add debug logs to deps update

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/single-executable

@marco-ippolito marco-ippolito changed the title tools: add debug logs tools: add debug logs to deps update May 18, 2023
@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label May 18, 2023
@tniessen
Copy link
Member

I still think we should be logging checksums of files that are downloaded (or commit IDs of commits that are checked out), see #47992 (review).

@marco-ippolito
Copy link
Member Author

I still think we should be logging checksums of files that are downloaded (or commit IDs of commits that are checked out), see #47992 (review).

Yes I've tracked it here: nodejs/security-wg#973, we might want checksum for all the zip we download

@marco-ippolito marco-ippolito added the commit-queue Add this label to land a pull request using GitHub Actions. label May 22, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 22, 2023
@nodejs-github-bot nodejs-github-bot merged commit f858dc5 into main May 22, 2023
27 checks passed
@nodejs-github-bot nodejs-github-bot deleted the feat/add-debug-logs branch May 22, 2023 08:22
@nodejs-github-bot
Copy link
Collaborator

Landed in f858dc5

fasenderos pushed a commit to fasenderos/node that referenced this pull request May 22, 2023
@marco-ippolito @fasenderos
tools: add debug logs
03a7ff1 
PR-URL: nodejs#48060
Reviewed-By: Ruy Adorno <ruyadorno@google.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
fasenderos pushed a commit to fasenderos/node that referenced this pull request May 22, 2023
@marco-ippolito @fasenderos
tools: add debug logs
c8484e4 
PR-URL: nodejs#48060
Reviewed-By: Ruy Adorno <ruyadorno@google.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit that referenced this pull request May 30, 2023
@marco-ippolito @targos
tools: add debug logs
2226088 
PR-URL: #48060
Reviewed-By: Ruy Adorno <ruyadorno@google.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@targos targos mentioned this pull request Jun 4, 2023
Merged
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
@marco-ippolito @danielleadams
tools: add debug logs
177ea90 
PR-URL: #48060
Reviewed-By: Ruy Adorno <ruyadorno@google.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MoLow pushed a commit to MoLow/node that referenced this pull request Jul 6, 2023
@marco-ippolito @MoLow
tools: add debug logs
0b0818c 
PR-URL: nodejs#48060
Reviewed-By: Ruy Adorno <ruyadorno@google.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@danielleadams danielleadams mentioned this pull request Jul 10, 2023
Merged
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@marco-ippolito @Ceres6
tools: add debug logs
caac5f3 
PR-URL: nodejs#48060
Reviewed-By: Ruy Adorno <ruyadorno@google.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@marco-ippolito @Ceres6
tools: add debug logs
121c28f 
PR-URL: nodejs#48060
Reviewed-By: Ruy Adorno <ruyadorno@google.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruyadorno ruyadorno ruyadorno approved these changes

@lpinca lpinca lpinca approved these changes

@richardlau richardlau richardlau approved these changes

@deokjinkim deokjinkim deokjinkim approved these changes

@RaisinTen RaisinTen RaisinTen approved these changes

@Mesteery Mesteery Mesteery approved these changes

Assignees
No one assigned
Labels
tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@marco-ippolito @nodejs-github-bot @tniessen @ruyadorno @lpinca @richardlau @deokjinkim @RaisinTen @Mesteery