Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "bun" export condition to common export conditions #48407

Closed
wants to merge 1 commit into from
Closed

Add "bun" export condition to common export conditions #48407

wants to merge 1 commit into from

Conversation

jcbhmr
Copy link
Contributor

@jcbhmr jcbhmr commented Jun 9, 2023

I need to change my commit message because I read https://github.com/nodejs/node/blob/HEAD/doc/contributing/pull-requests.md#commit-message-guidelines after making the tiny change 馃ぃ

For reference on the "bun" export condition: https://bun.sh/docs/runtime/modules#resolution
image

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/loaders
  • @nodejs/modules

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Jun 9, 2023
@guybedford
Copy link
Contributor

Rather than expanding this section to every platform, it may be better at this point to reference the list at https://runtime-keys.proposal.wintercg.org/ directly here.

@jcbhmr
Copy link
Contributor Author

jcbhmr commented Jun 10, 2023

Good point! Though I note that https://runtime-keys.proposal.wintercg.org/ doesn't include the "types" condition which the Node.js docs do. It also doesn't include "browser", "development" or "production". Maybe it would be best to keep only Node.js-ish stuff like this (below)?

  • "types"
  • "browser"
  • "react-native"
  • "development"
  • "production"

note the lack of "deno" and "bun"
and then a link to the https://runtime-keys.proposal.wintercg.org/ ?

@guybedford
Copy link
Contributor

That sounds sensible to me - now that these keys have a definition elsewhere, it would make sense to avoid duplication for them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants