doc: fix typo in events.md #48436
Merged
doc: fix typo in events.md #48436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Darshan Sen <raisinten@gmail.com>
RaisinTen
added
the
fast-track
|
Fast-track has been requested by @RaisinTen. Please 👍 to approve. |
nodejs-github-bot
added
doc
cjihrig
approved these changes
Jun 12, 2023
RaisinTen
added
the
author ready
MoLow
approved these changes
Jun 12, 2023
debadree25
added
the
commit-queue
lpinca
approved these changes
Jun 12, 2023
nodejs-github-bot
removed
the
commit-queue
|
Landed in 4e0066e |
nodejs-github-bot
added
the
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/48436 ✔ Done loading data for nodejs/node/pull/48436 ----------------------------------- PR info ------------------------------------ Title doc: fix typo in events.md (#48436) Author Darshan Sen (@RaisinTen) Branch RaisinTen:doc-fix-typo-in-events.md -> nodejs:main Labels doc, events, fast-track, author ready Commits 1 - doc: fix typo in events.md Committers 1 - Darshan Sen PR-URL: https://github.com/nodejs/node/pull/48436 Reviewed-By: Colin Ihrig Reviewed-By: Moshe Atlow Reviewed-By: Luigi Pinca ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/48436 Reviewed-By: Colin Ihrig Reviewed-By: Moshe Atlow Reviewed-By: Luigi Pinca -------------------------------------------------------------------------------- ℹ This PR was created on Mon, 12 Jun 2023 13:23:41 GMT ✔ Approvals: 3 ✔ - Colin Ihrig (@cjihrig) (TSC): https://github.com/nodejs/node/pull/48436#pullrequestreview-1474924898 ✔ - Moshe Atlow (@MoLow) (TSC): https://github.com/nodejs/node/pull/48436#pullrequestreview-1475008547 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/48436#pullrequestreview-1475298533 ℹ This PR is being fast-tracked ⚠ This PR was merged on Mon, 12 Jun 2023 16:15:04 GMT ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/5246072814 |
Commit Queue failed- Loading data for nodejs/node/pull/48436 ✔ Done loading data for nodejs/node/pull/48436 ----------------------------------- PR info ------------------------------------ Title doc: fix typo in events.md (#48436) Author Darshan Sen (@RaisinTen) Branch RaisinTen:doc-fix-typo-in-events.md -> nodejs:main Labels doc, events, fast-track, author ready, commit-queue-failed Commits 1 - doc: fix typo in events.md Committers 1 - Darshan Sen PR-URL: https://github.com/nodejs/node/pull/48436 Reviewed-By: Colin Ihrig Reviewed-By: Moshe Atlow Reviewed-By: Luigi Pinca ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/48436 Reviewed-By: Colin Ihrig Reviewed-By: Moshe Atlow Reviewed-By: Luigi Pinca -------------------------------------------------------------------------------- ℹ This PR was created on Mon, 12 Jun 2023 13:23:41 GMT ✔ Approvals: 3 ✔ - Colin Ihrig (@cjihrig) (TSC): https://github.com/nodejs/node/pull/48436#pullrequestreview-1474924898 ✔ - Moshe Atlow (@MoLow) (TSC): https://github.com/nodejs/node/pull/48436#pullrequestreview-1475008547 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/48436#pullrequestreview-1475298533 ℹ This PR is being fast-tracked ⚠ This PR was merged on Mon, 12 Jun 2023 16:15:04 GMT ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/5246167439 |
RafaelGSS
pushed a commit
that referenced
this pull request
Jul 3, 2023
Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: #48436 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
Ceres6
pushed a commit
to Ceres6/node
that referenced
this pull request
Aug 14, 2023
Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: nodejs#48436 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Ceres6
pushed a commit
to Ceres6/node
that referenced
this pull request
Aug 14, 2023
Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: nodejs#48436 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
ruyadorno
pushed a commit
that referenced
this pull request
Sep 7, 2023
Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: #48436 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
ruyadorno
pushed a commit
that referenced
this pull request
Sep 13, 2023
Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: #48436 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.