Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix nonsensical grammar in Buffer::write #4863

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
6 participants
@Jimbly
Copy link
Contributor

commented Jan 25, 2016

No description provided.

@mscdex mscdex added buffer doc labels Jan 25, 2016

@evanlucas

This comment has been minimized.

Copy link
Member

commented Jan 26, 2016

LGTM

1 similar comment
@cjihrig

This comment has been minimized.

Copy link
Contributor

commented Jan 26, 2016

LGTM

silverwind added a commit that referenced this pull request Jan 26, 2016

doc: fix nonsensical grammar in Buffer::write
PR-URL: #4863
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
@silverwind

This comment has been minimized.

Copy link
Contributor

commented Jan 26, 2016

Thanks! Landed in 5808642.

@silverwind silverwind closed this Jan 26, 2016

rvagg added a commit that referenced this pull request Jan 27, 2016

doc: fix nonsensical grammar in Buffer::write
PR-URL: #4863
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>

benjamingr added a commit to benjamingr/io.js that referenced this pull request Jan 27, 2016

doc: fix nonsensical grammar in Buffer::write
PR-URL: nodejs#4863
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>

rvagg added a commit that referenced this pull request Feb 8, 2016

doc: fix nonsensical grammar in Buffer::write
PR-URL: #4863
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>

MylesBorins added a commit that referenced this pull request Feb 22, 2016

doc: fix nonsensical grammar in Buffer::write
PR-URL: #4863
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>

MylesBorins added a commit that referenced this pull request Feb 22, 2016

doc: fix nonsensical grammar in Buffer::write
PR-URL: #4863
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>

MylesBorins added a commit that referenced this pull request Mar 2, 2016

doc: fix nonsensical grammar in Buffer::write
PR-URL: #4863
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>

scovetta pushed a commit to scovetta/node that referenced this pull request Apr 2, 2016

doc: fix nonsensical grammar in Buffer::write
PR-URL: nodejs#4863
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.