Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: attach error to stack on displayErrors #4874

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
3 participants
@cjihrig
Copy link
Contributor

commented Jan 26, 2016

The vm module's displayErrors option attaches error arrow messages as a hidden property. Later, core JavaScript code can optionally decorate the error stack with the arrow message. However, when user code catches an error, it has no way to access the arrow message. This commit changes the behavior of displayErrors to mean "decorate the error stack if an error occurs."

Fixes: #4835
R= @bnoordhuis

src: attach error to stack on displayErrors
The vm module's displayErrors option attaches error arrow
messages as a hidden property. Later, core JavaScript code
can optionally decorate the error stack with the arrow message.
However, when user code catches an error, it has no way to
access the arrow message. This commit changes the behavior of
displayErrors to mean "decorate the error stack if an error
occurs."

Fixes: #4835

@mscdex mscdex added the vm label Jan 26, 2016

@bnoordhuis

This comment has been minimized.

Copy link
Member

commented Jan 26, 2016

LGTM

@cjihrig

This comment has been minimized.

Copy link
Contributor Author

commented Jan 26, 2016

cjihrig added a commit that referenced this pull request Jan 26, 2016

src: attach error to stack on displayErrors
The vm module's displayErrors option attaches error arrow
messages as a hidden property. Later, core JavaScript code
can optionally decorate the error stack with the arrow message.
However, when user code catches an error, it has no way to
access the arrow message. This commit changes the behavior of
displayErrors to mean "decorate the error stack if an error
occurs."

Fixes: #4835
PR-URL: #4874
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
@cjihrig

This comment has been minimized.

Copy link
Contributor Author

commented Jan 26, 2016

Thanks for the review! CI was all green. Landed in 5700352.

@cjihrig cjihrig closed this Jan 26, 2016

@cjihrig cjihrig deleted the cjihrig:disp-errs branch Jan 26, 2016

benjamingr added a commit to benjamingr/io.js that referenced this pull request Jan 27, 2016

src: attach error to stack on displayErrors
The vm module's displayErrors option attaches error arrow
messages as a hidden property. Later, core JavaScript code
can optionally decorate the error stack with the arrow message.
However, when user code catches an error, it has no way to
access the arrow message. This commit changes the behavior of
displayErrors to mean "decorate the error stack if an error
occurs."

Fixes: nodejs#4835
PR-URL: nodejs#4874
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

@jasnell jasnell referenced this pull request Mar 17, 2016

Closed

Planning for v6 #5766

scovetta pushed a commit to scovetta/node that referenced this pull request Apr 2, 2016

src: attach error to stack on displayErrors
The vm module's displayErrors option attaches error arrow
messages as a hidden property. Later, core JavaScript code
can optionally decorate the error stack with the arrow message.
However, when user code catches an error, it has no way to
access the arrow message. This commit changes the behavior of
displayErrors to mean "decorate the error stack if an error
occurs."

Fixes: nodejs#4835
PR-URL: nodejs#4874
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.