Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: relocate test files fixtures for better understanding #48787

Merged
merged 8 commits into from Jul 26, 2023
Merged

test: relocate test files fixtures for better understanding #48787

merged 8 commits into from Jul 26, 2023

Conversation

rluvaton
Copy link
Member

@rluvaton rluvaton commented Jul 15, 2023 •
edited

move all files that the test runner used by directory to their own folder

example of such a problem:

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/test_runner

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Jul 15, 2023
@rluvaton rluvaton changed the title test: reorder test files fixtures for better understanding test: relocate test files fixtures for better understanding Jul 16, 2023
@rluvaton
Copy link
Member Author

The failing macOS test is unrelated, it's about the inspector

@rluvaton
Copy link
Member Author

Cc @MoLow

@rluvaton rluvaton mentioned this pull request Jul 25, 2023
Merged
@rluvaton
Copy link
Member Author

Cc @benjamingr @cjihrig

@MoLow
Copy link
Member

MoLow commented Jul 26, 2023

@rluvaton can you fix failing tests?

@rluvaton
Copy link
Member Author

rluvaton commented Jul 26, 2023 •
edited

Hey, because more than a week passed a single reviewer is enough no? (because it blocking other PR and this is just test fixture relocation)

@MoLow MoLow added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 26, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 26, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52940/

@atlowChemi atlowChemi added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Jul 26, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 26, 2023
@nodejs-github-bot nodejs-github-bot merged commit bcaf198 into nodejs:main Jul 26, 2023
61 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in bcaf198

@rluvaton
Copy link
Member Author

Thanks

Ceres6 pushed a commit to Ceres6/node that referenced this pull request Jul 27, 2023
@rluvaton @Ceres6
test: reorder test files fixtures for better understanding
6474b68 
PR-URL: nodejs#48787
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
pluris pushed a commit to pluris/node that referenced this pull request Aug 6, 2023
@rluvaton @pluris
test: reorder test files fixtures for better understanding
43755ac 
PR-URL: nodejs#48787
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
pluris pushed a commit to pluris/node that referenced this pull request Aug 7, 2023
@rluvaton @pluris
test: reorder test files fixtures for better understanding
22c1da2 
PR-URL: nodejs#48787
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@rluvaton @Ceres6
test: reorder test files fixtures for better understanding
945dabc 
PR-URL: nodejs#48787
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@rluvaton @Ceres6
test: reorder test files fixtures for better understanding
e5f6106 
PR-URL: nodejs#48787
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
@UlisesGascon
Copy link
Member

This PR didn't land cleanly on node 20. Could you please make a backport?

@rluvaton
Copy link
Member Author

Sure, can you tell me what was the problem?

@RafaelGSS RafaelGSS added the backport-requested-v20.x PRs awaiting manual backport to the v20.x-staging branch. label Aug 14, 2023
@RafaelGSS
Copy link
Member

Sure, can you tell me what was the problem?

If you cherry-pick bcaf198 on v20.x-staging you should see the conflicts. Basically, it touches on some parts of #47653 which is a semver-major and won't go to v20.x.

rluvaton added a commit to rluvaton/node that referenced this pull request Aug 14, 2023
@rluvaton
test: reorder test files fixtures for better understanding
cb816ec 
PR-URL: nodejs#48787
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
@rluvaton rluvaton mentioned this pull request Aug 14, 2023
Closed
rluvaton added a commit to rluvaton/node that referenced this pull request Aug 14, 2023
@rluvaton
test: reorder test files fixtures for better understanding
6514d06 
Backport-PR-URL: nodejs#49174
PR-URL: nodejs#48787
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
@RafaelGSS RafaelGSS added backport-open-v20.x Indicate that the PR has an open backport and removed backport-requested-v20.x PRs awaiting manual backport to the v20.x-staging branch. labels Aug 14, 2023
rluvaton added a commit to rluvaton/node that referenced this pull request Aug 15, 2023
@rluvaton
test: reorder test files fixtures for better understanding
2dca814 
PR-URL: nodejs#48787
Backport-PR-URL: nodejs#49174
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
rluvaton added a commit to rluvaton/node that referenced this pull request Aug 15, 2023
@rluvaton
test: reorder test files fixtures for better understanding
7c07077 
PR-URL: nodejs#48787
Backport-PR-URL: nodejs#49174
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
rluvaton added a commit to rluvaton/node that referenced this pull request Aug 15, 2023
@rluvaton
test: reorder test files fixtures for better understanding
c81e537 
PR-URL: nodejs#48787
Backport-PR-URL: nodejs#49174
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
@rluvaton rluvaton mentioned this pull request Aug 18, 2023
Closed
rluvaton added a commit to rluvaton/node that referenced this pull request Aug 18, 2023
@rluvaton
test: reorder test files fixtures for better understanding
d8cea5d 
PR-URL: nodejs#48787
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
@rluvaton
Copy link
Member Author

Backport PR:

rluvaton added a commit to rluvaton/node that referenced this pull request Sep 4, 2023
@rluvaton
test: reorder test files fixtures for better understanding
2e0df36 
PR-URL: nodejs#48787
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
UlisesGascon pushed a commit that referenced this pull request Sep 10, 2023
@rluvaton @UlisesGascon
test: reorder test files fixtures for better understanding
25e967a 
PR-URL: #48787
Backport-PR-URL: #49225
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
@UlisesGascon UlisesGascon mentioned this pull request Sep 10, 2023
Merged
@targos targos added backported-to-v20.x PRs backported to the v20.x-staging branch. and removed backport-open-v20.x Indicate that the PR has an open backport labels Nov 12, 2023
targos pushed a commit that referenced this pull request Nov 27, 2023
@rluvaton @targos
test: reorder test files fixtures for better understanding
0fea550 
PR-URL: #48787
Backport-PR-URL: #49225
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
@targos targos mentioned this pull request Nov 28, 2023
Merged
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
test: reorder test files fixtures for better understanding
9207a54 
PR-URL: nodejs/node#48787
Backport-PR-URL: nodejs/node#49225
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
test: reorder test files fixtures for better understanding
28711e8 
PR-URL: nodejs/node#48787
Backport-PR-URL: nodejs/node#49225
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MoLow MoLow MoLow approved these changes

@atlowChemi atlowChemi atlowChemi approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. backported-to-v20.x PRs backported to the v20.x-staging branch. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@rluvaton @nodejs-github-bot @MoLow @UlisesGascon @RafaelGSS @atlowChemi @targos