dns: coerce port to number in lookupService #4883
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evanlucas
added
dns
|
LGTM |
|
/cc @mscdex since this was your suggestion |
|
LGTM |
2 similar comments
|
LGTM |
|
LGTM |
|
LGTM. Why is this semver-major? |
|
It changes behavior. Before one could pass 10000000 as the port. Now a TypeError will be thrown. It also accepts a string that can be coerced into a number that is a valid port. Before it did not |
evanlucas
force-pushed
the
dnsnet-internal2
branch
from
65e92db
to
16d8e62
Compare
|
Rebased and running CI one more time: https://ci.nodejs.org/job/node-test-pull-request/1470/ |
|
This probably warrants a doc update and some additional tests. I will add those and then run CI again. Sorry for omitting them in the first place. |
evanlucas
force-pushed
the
dnsnet-internal2
branch
from
16d8e62
to
8c2cb44
Compare
|
Ok, docs updated and additional tests added. PTAL |
| @@ -126,6 +126,10 @@ on some operating systems (e.g FreeBSD 10.1). | |||
| Resolves the given `address` and `port` into a hostname and service using | |||
| the operating system's underlying `getnameinfo` implementation. | |||
|
|
|||
| If `address` is not a valid IP address, a TypeError will be thrown. | |||
There was a problem hiding this comment.
Can you add backticks around TypeError here and below.
|
Still LGTM with one small comment. |
Previously, port could be any number in dns.lookupService. This change throws a TypeError if port is outside the range of 0-65535. It also coerces the port to a number.
evanlucas
force-pushed
the
dnsnet-internal2
branch
from
8c2cb44
to
2e87682
Compare
|
Fixed |
|
LGTM |
jasnell
pushed a commit
that referenced
this pull request
Feb 1, 2016
Previously, port could be any number in dns.lookupService. This change throws a TypeError if port is outside the range of 0-65535. It also coerces the port to a number. PR-URL: #4883 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Minwoo Jung <jmwsoft@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
|
Landed in f3be421 |
Closed
scovetta
pushed a commit
to scovetta/node
that referenced
this pull request
Apr 2, 2016
Previously, port could be any number in dns.lookupService. This change throws a TypeError if port is outside the range of 0-65535. It also coerces the port to a number. PR-URL: nodejs#4883 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Minwoo Jung <jmwsoft@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, port could be any number in dns.lookupService. This change
throws a TypeError if port is outside the range of 0-65535. It also
coerces the port to a number.
This includes the commit from #4882 as it depends on it.
I have separated them into two PRs for the sake of cherry-picking to release branches though as this is semver-major.