Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib,permission: drop repl autocomplete when pm enabled #48920

Merged
merged 1 commit into from Jul 27, 2023
Merged

lib,permission: drop repl autocomplete when pm enabled #48920

merged 1 commit into from Jul 27, 2023

Conversation

RafaelGSS
Copy link
Member

Fixes: #48884

I'll add some tests for it

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. repl Issues and PRs related to the REPL subsystem. labels Jul 25, 2023
@RafaelGSS RafaelGSS mentioned this pull request Jul 25, 2023
Closed
@MoLow
Copy link
Member

MoLow commented Jul 25, 2023

missing tests

targos
targos previously requested changes Jul 25, 2023
View reviewed changes
Copy link
Member

@targos targos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be more correct to update the condition in

node/lib/internal/util/inspector.js

Line 49 in 36c72c8

if (!hasInspector) return onError();

The REPL already handles the error case (when Node.js is built without inspector support)

@RafaelGSS RafaelGSS requested a review from targos July 25, 2023 17:37
@RafaelGSS RafaelGSS added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 25, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 25, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52929/

@RafaelGSS RafaelGSS requested a review from tniessen July 25, 2023 22:54
@RafaelGSS RafaelGSS added the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 26, 2023
@RafaelGSS RafaelGSS added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Jul 27, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 27, 2023
@nodejs-github-bot nodejs-github-bot merged commit b907815 into nodejs:main Jul 27, 2023
58 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in b907815

Ceres6 pushed a commit to Ceres6/node that referenced this pull request Jul 27, 2023
@RafaelGSS @Ceres6
lib,permission: drop repl autocomplete when pm enabled
3300fe7 
PR-URL: nodejs#48920
Fixes: nodejs#48884
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
rluvaton pushed a commit to rluvaton/node that referenced this pull request Jul 28, 2023
@RafaelGSS @rluvaton
lib,permission: drop repl autocomplete when pm enabled
e57e3b9 
PR-URL: nodejs#48920
Fixes: nodejs#48884
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
pluris pushed a commit to pluris/node that referenced this pull request Aug 6, 2023
@RafaelGSS @pluris
lib,permission: drop repl autocomplete when pm enabled
6ddc1f3 
PR-URL: nodejs#48920
Fixes: nodejs#48884
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
pluris pushed a commit to pluris/node that referenced this pull request Aug 7, 2023
@RafaelGSS @pluris
lib,permission: drop repl autocomplete when pm enabled
bca4678 
PR-URL: nodejs#48920
Fixes: nodejs#48884
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@tniessen tniessen added the permission Issues and PRs related to the Permission Model label Aug 10, 2023
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@RafaelGSS @Ceres6
lib,permission: drop repl autocomplete when pm enabled
04e4d99 
PR-URL: nodejs#48920
Fixes: nodejs#48884
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@RafaelGSS @Ceres6
lib,permission: drop repl autocomplete when pm enabled
5ba1580 
PR-URL: nodejs#48920
Fixes: nodejs#48884
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
UlisesGascon pushed a commit to UlisesGascon/node that referenced this pull request Aug 14, 2023
@RafaelGSS @UlisesGascon
lib,permission: drop repl autocomplete when pm enabled
ee2c23a 
PR-URL: nodejs#48920
Fixes: nodejs#48884
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
RafaelGSS added a commit that referenced this pull request Aug 15, 2023
@RafaelGSS
lib,permission: drop repl autocomplete when pm enabled
6446346 
PR-URL: #48920
Fixes: #48884
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@UlisesGascon UlisesGascon mentioned this pull request Aug 15, 2023
Merged
RafaelGSS added a commit that referenced this pull request Aug 17, 2023
@RafaelGSS
lib,permission: drop repl autocomplete when pm enabled
a12ce11 
PR-URL: #48920
Fixes: #48884
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShogunPanda ShogunPanda ShogunPanda approved these changes

@Trott Trott Trott approved these changes

@tniessen tniessen tniessen approved these changes

@targos targos Awaiting requested review from targos

Assignees
No one assigned
Labels
needs-ci PRs that need a full CI run. permission Issues and PRs related to the Permission Model repl Issues and PRs related to the REPL subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

--experimental-permission breaks REPL
7 participants
@RafaelGSS @MoLow @nodejs-github-bot @ShogunPanda @Trott @targos @tniessen