Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

report: fix recent coverity warning. #48954

Closed
wants to merge 2 commits into from
Closed

report: fix recent coverity warning. #48954

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
67e7828
report: fix recent coverity warning
mhdawson Jul 28, 2023
2b1c683
Update src/node_report.cc
mhdawson Aug 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 7 additions & 3 deletions src/node_report.cc
View file
Open in desktop
Expand Up @@ -857,9 +857,13 @@ std::string TriggerNodeReport(Isolate* isolate,
// Determine the required report filename. In order of priority:
// 1) supplied on API 2) configured on startup 3) default generated
if (!name.empty()) {
THROW_IF_INSUFFICIENT_PERMISSIONS(
env, permission::PermissionScope::kFileSystemWrite, name, name);
// Filename was specified as API parameter.
// we may not always be in a great state when generating a node report
// allow for the case where we don't have an env
if (env != nullptr) {
anonrig marked this conversation as resolved.
Show resolved Hide resolved
mhdawson marked this conversation as resolved.
Show resolved Hide resolved
THROW_IF_INSUFFICIENT_PERMISSIONS(
env, permission::PermissionScope::kFileSystemWrite, name, name);
// Filename was specified as API parameter.
}
mhdawson marked this conversation as resolved.
Show resolved Hide resolved
filename = name;
} else {
std::string report_filename;
Expand Down