src: use ARES_SUCCESS instead of 0 #49048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
c++
ShogunPanda
approved these changes
Aug 7, 2023
lpinca
approved these changes
Aug 7, 2023
daeyeon
approved these changes
Aug 9, 2023
github-actions
bot
removed
the
request-ci
deokjinkim
approved these changes
Aug 11, 2023
deokjinkim
added
the
author ready
29 tasks
This was referenced Aug 14, 2023
24 tasks
github-actions
bot
removed
the
request-ci
26 tasks
32 tasks
pluris
force-pushed
the
fix/return_value_ares
branch
from
b39c68a
to
a50acf8
Compare
github-actions
bot
removed
the
request-ci
deokjinkim
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/49048 ✔ Done loading data for nodejs/node/pull/49048 ----------------------------------- PR info ------------------------------------ Title src: use ARES_SUCCESS instead of 0 (#49048) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch pluris:fix/return_value_ares -> nodejs:main Labels c++, cares, author ready, needs-ci Commits 1 - src: use ARES_SUCCESS instead of 0 Committers 1 - pluris PR-URL: https://github.com/nodejs/node/pull/49048 Refs: https://github.com/nodejs/node/pull/48834 Reviewed-By: Paolo Insogna Reviewed-By: Luigi Pinca Reviewed-By: Matteo Collina Reviewed-By: Daeyeon Jeong Reviewed-By: Deokjin Kim ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/49048 Refs: https://github.com/nodejs/node/pull/48834 Reviewed-By: Paolo Insogna Reviewed-By: Luigi Pinca Reviewed-By: Matteo Collina Reviewed-By: Daeyeon Jeong Reviewed-By: Deokjin Kim -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last approving review: ⚠ - src: use ARES_SUCCESS instead of 0 ℹ This PR was created on Mon, 07 Aug 2023 02:09:49 GMT ✔ Approvals: 5 ✔ - Paolo Insogna (@ShogunPanda): https://github.com/nodejs/node/pull/49048#pullrequestreview-1564608652 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/49048#pullrequestreview-1566030900 ✔ - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/49048#pullrequestreview-1566746791 ✔ - Daeyeon Jeong (@daeyeon): https://github.com/nodejs/node/pull/49048#pullrequestreview-1569578439 ✔ - Deokjin Kim (@deokjinkim): https://github.com/nodejs/node/pull/49048#pullrequestreview-1573692692 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2023-08-20T03:14:04Z: https://ci.nodejs.org/job/node-test-pull-request/53456/ - Querying data for job/node-test-pull-request/53456/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/5916677346 |
deokjinkim
removed
the
commit-queue-failed
deokjinkim
approved these changes
Aug 20, 2023
deokjinkim
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 982e7a6 |
This was referenced Aug 21, 2023
Merged
sercher
added a commit
to sercher/graaljs
that referenced
this pull request
Apr 25, 2024
PR-URL: nodejs/node#49048 Refs: nodejs/node#48834 Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
sercher
added a commit
to sercher/graaljs
that referenced
this pull request
Apr 25, 2024
PR-URL: nodejs/node#49048 Refs: nodejs/node#48834 Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added missing changes in the PR.
Refs : #48834