Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test_runner: fix test runner watch mode when no positional arguments #49578

Merged
merged 1 commit into from Sep 14, 2023
Merged

test_runner: fix test runner watch mode when no positional arguments #49578

merged 1 commit into from Sep 14, 2023

Conversation

MoLow
Copy link
Member

@MoLow MoLow commented Sep 9, 2023 •
edited

Fixes: #49617
I cannot reproduce the original error reported in #49544
but this fixes the issue in the comment

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/test_runner

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Sep 9, 2023
@Gabriel-Tapes
Copy link

I cannot reproduce the original error reported in #49544

The issue I reported in #49544 is probably related to the compilation done by Arch Linux, so I'm closing it.

@atlowChemi atlowChemi added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. test_runner watch-mode Issues and PRs related to watch mode labels Sep 11, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 11, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53896/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53899/

@github-actions github-actions bot mentioned this pull request Sep 12, 2023
Open
19 tasks
@Linkgoron Linkgoron mentioned this pull request Sep 12, 2023
Closed
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53916/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53918/

This was referenced Sep 13, 2023
Open
Open
@MoLow MoLow added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 14, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 14, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53947/

@MoLow MoLow added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 14, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 14, 2023
@nodejs-github-bot nodejs-github-bot merged commit 1a4ae46 into nodejs:main Sep 14, 2023
55 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 1a4ae46

@MoLow MoLow deleted the watch-mode-with-test branch September 14, 2023 11:48
This was referenced Sep 15, 2023
Open
Open
Open
ruyadorno pushed a commit that referenced this pull request Sep 28, 2023
@MoLow @ruyadorno
test_runner: fix test runner watch mode when no positional arguments
7686551 
PR-URL: #49578
Fixes: #49617
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
This was referenced Sep 28, 2023
Closed
Merged
alexfernandez pushed a commit to alexfernandez/node that referenced this pull request Nov 1, 2023
@MoLow @alexfernandez
test_runner: fix test runner watch mode when no positional arguments
36eb175 
PR-URL: nodejs#49578
Fixes: nodejs#49617
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
targos pushed a commit that referenced this pull request Nov 27, 2023
@MoLow @targos
test_runner: fix test runner watch mode when no positional arguments
e459598 
PR-URL: #49578
Fixes: #49617
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@targos targos mentioned this pull request Nov 28, 2023
Merged
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
test_runner: fix test runner watch mode when no positional
751e807 
PR-URL: nodejs/node#49578
Fixes: nodejs/node#49617
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
test_runner: fix test runner watch mode when no positional
be1211d 
PR-URL: nodejs/node#49578
Fixes: nodejs/node#49617
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjamingr benjamingr benjamingr approved these changes

@UlisesGascon UlisesGascon UlisesGascon approved these changes

@atlowChemi atlowChemi atlowChemi approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. test_runner watch-mode Issues and PRs related to watch mode
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

'node --test --watch' fails: node: --watch requires specifying a file
6 participants
@MoLow @nodejs-github-bot @Gabriel-Tapes @benjamingr @UlisesGascon @atlowChemi