doc: apply consistent styling for functions #4974
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Always refer to (for example) `assert.deepEqual()` as `assert.deepEqual()` and never as `assert.deepEqual`.
|
LGTM. |
| @@ -89,7 +89,7 @@ parameter is undefined, a default error message is assigned. | |||
|
|
|||
| ## assert.deepStrictEqual(actual, expected[, message]) | |||
|
|
|||
| Generally identical to `assert.deepEqual` with the exception that primitive | |||
| Generally identical to `assert.deepEqual()` with the exception that primitive | |||
There was a problem hiding this comment.
Nitpick, but shouldn't that also be a link (i.e. [assert.deepEqual()][] )
|
Looks good. I'm planning on submitting a more comprehensive PR that fixes all such cases in the API documentation, but for now this can go in. |
|
Awesome. LGTM. I am on Mobile. I couldn't check all the places in this file. Hope you took care of all of them |
|
LGTM |
|
Just added one minor change to this at the suggestion of @benjamingr. @thefourtheye and/or @Qard: Can you check the minor update and confirm that it still looks good to you? |
|
Yep, LGTM. 👍 |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Feb 2, 2016
Always refer to (for example) `assert.deepEqual()` as `assert.deepEqual()` and never as `assert.deepEqual`. PR-URL: nodejs#4974 Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
|
Landed in 3874f32 |
rvagg
pushed a commit
that referenced
this pull request
Feb 8, 2016
Always refer to (for example) `assert.deepEqual()` as `assert.deepEqual()` and never as `assert.deepEqual`. PR-URL: #4974 Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
|
blocked by e436272 |
|
@thealphanerd can I help there? |
|
@eljefedelrodeodeljefe not just yet. That commit itself is blocked by another one. |
MylesBorins
pushed a commit
that referenced
this pull request
Feb 22, 2016
Always refer to (for example) `assert.deepEqual()` as `assert.deepEqual()` and never as `assert.deepEqual`. PR-URL: #4974 Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
MylesBorins
pushed a commit
that referenced
this pull request
Feb 22, 2016
Always refer to (for example) `assert.deepEqual()` as `assert.deepEqual()` and never as `assert.deepEqual`. PR-URL: #4974 Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 2, 2016
Always refer to (for example) `assert.deepEqual()` as `assert.deepEqual()` and never as `assert.deepEqual`. PR-URL: #4974 Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
scovetta
pushed a commit
to scovetta/node
that referenced
this pull request
Apr 2, 2016
Always refer to (for example) `assert.deepEqual()` as `assert.deepEqual()` and never as `assert.deepEqual`. PR-URL: nodejs#4974 Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Always refer to (for example)
assert.deepEqual()asassert.deepEqual()and never asassert.deepEqual./cc @nodejs/documentation @thefourtheye