Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

buffer: remove unnecessary assignment in fromString #50199

Merged
merged 1 commit into from Oct 19, 2023
Merged

buffer: remove unnecessary assignment in fromString #50199

merged 1 commit into from Oct 19, 2023

Conversation

tniessen
Copy link
Member

The assignment to the encoding variable has no effect.

Refs: #29217

@tniessen
buffer: remove unnecessary assignment in fromString
8bdd921 
The assignment to the encoding variable has no effect.

Refs: nodejs#29217
@tniessen tniessen added the buffer Issues and PRs related to the buffer subsystem. label Oct 16, 2023
@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Oct 16, 2023
@tniessen tniessen added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 17, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 17, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54891/

@tniessen tniessen added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Oct 18, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 19, 2023
@nodejs-github-bot nodejs-github-bot merged commit e45e73b into nodejs:main Oct 19, 2023
63 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in e45e73b

targos pushed a commit that referenced this pull request Oct 23, 2023
@tniessen @targos
buffer: remove unnecessary assignment in fromString
9cd68b9 
The assignment to the encoding variable has no effect.

Refs: #29217
PR-URL: #50199
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@targos targos mentioned this pull request Oct 23, 2023
Merged
alexfernandez pushed a commit to alexfernandez/node that referenced this pull request Nov 1, 2023
@tniessen @alexfernandez
buffer: remove unnecessary assignment in fromString
9c5be79 
The assignment to the encoding variable has no effect.

Refs: nodejs#29217
PR-URL: nodejs#50199
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit that referenced this pull request Nov 11, 2023
@tniessen @targos
buffer: remove unnecessary assignment in fromString
458d9a8 
The assignment to the encoding variable has no effect.

Refs: #29217
PR-URL: #50199
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@targos targos mentioned this pull request Nov 12, 2023
Merged
@juanarbol juanarbol mentioned this pull request Dec 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@anonrig anonrig anonrig approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. buffer Issues and PRs related to the buffer subsystem. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tniessen @nodejs-github-bot @lpinca @anonrig