test: replace forEach() with for ... of in test-tls-getprotocol.js #50600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
marco-ippolito
added
the
code-and-learn
lpinca
approved these changes
Nov 8, 2023
github-actions
bot
removed
the
request-ci
20 tasks
SociableSteve
force-pushed
the
test-tls-getprotocol
branch
from
2d9d4fd
to
b29f473
Compare
SociableSteve
changed the title
|
I've fixed the linting fail, and updated the commit message to have lower case after the module. |
github-actions
bot
removed
the
request-ci
This was referenced Nov 10, 2023
lpinca
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/50600 ✔ Done loading data for nodejs/node/pull/50600 ----------------------------------- PR info ------------------------------------ Title test: replace forEach() with for ... of in test-tls-getprotocol.js (#50600) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch SociableSteve:test-tls-getprotocol -> nodejs:main Labels test, code-and-learn, needs-ci Commits 1 - test: replace forEach() with for ... of in test-tls-getprotocol.js Committers 1 - Steve Goode PR-URL: https://github.com/nodejs/node/pull/50600 Reviewed-By: Luigi Pinca ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/50600 Reviewed-By: Luigi Pinca -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last approving review: ⚠ - test: replace forEach() with for ... of in test-tls-getprotocol.js ℹ This PR was created on Tue, 07 Nov 2023 15:14:37 GMT ✔ Approvals: 1 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/50600#pullrequestreview-1721284283 ℹ This PR is being fast-tracked because it is from a Code and Learn event ⚠ GitHub cannot link the author of 'test: replace forEach() with for ... of in test-tls-getprotocol.js' to their GitHub account. ⚠ Please suggest them to take a look at https://github.com/nodejs/node/blob/99b1ada/doc/guides/contributing/pull-requests.md#step-1-fork ✔ Last GitHub CI successful ℹ Last Full PR CI on 2023-11-09T13:08:52Z: https://ci.nodejs.org/job/node-test-pull-request/55520/ - Querying data for job/node-test-pull-request/55520/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/6915774569 |
marco-ippolito
approved these changes
Nov 21, 2023
marco-ippolito
added
request-ci
nodejs-github-bot
removed
the
commit-queue
|
Landed in f22ba46 |
targos
pushed a commit
that referenced
this pull request
Nov 23, 2023
PR-URL: #50600 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
martenrichter
pushed a commit
to martenrichter/node
that referenced
this pull request
Nov 26, 2023
PR-URL: nodejs#50600 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
lucshi
pushed a commit
to lucshi/node
that referenced
this pull request
Nov 27, 2023
PR-URL: nodejs#50600 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Merged
RafaelGSS
pushed a commit
that referenced
this pull request
Nov 29, 2023
PR-URL: #50600 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
RafaelGSS
pushed a commit
that referenced
this pull request
Nov 30, 2023
PR-URL: #50600 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
UlisesGascon
pushed a commit
that referenced
this pull request
Dec 11, 2023
PR-URL: #50600 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Merged
UlisesGascon
pushed a commit
that referenced
this pull request
Dec 15, 2023
PR-URL: #50600 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
UlisesGascon
pushed a commit
that referenced
this pull request
Dec 19, 2023
PR-URL: #50600 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nodeconf 2023 replace forEach with for..of