src: refactor GetCreationContext calls
#51287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
c++
jasnell
approved these changes
Dec 25, 2023
github-actions
bot
removed
the
request-ci
UlisesGascon
approved these changes
Dec 26, 2023
lpinca
added
author ready
nodejs-github-bot
removed
the
commit-queue
Commit Queue failed- Loading data for nodejs/node/pull/51287 ✔ Done loading data for nodejs/node/pull/51287 ----------------------------------- PR info ------------------------------------ Title src: refactor `GetCreationContext` calls (#51287) Author Yagiz Nizipli (@anonrig) Branch anonrig:simplify-getcreationcontext -> nodejs:main Labels c++, lib / src, author ready, needs-ci Commits 1 - src: refactor `GetCreationContext` calls Committers 1 - Yagiz Nizipli PR-URL: https://github.com/nodejs/node/pull/51287 Reviewed-By: James M Snell ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/51287 Reviewed-By: James M Snell -------------------------------------------------------------------------------- ℹ This PR was created on Mon, 25 Dec 2023 18:53:40 GMT ✔ Approvals: 1 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/51287#pullrequestreview-1795959041 ✘ This PR needs to wait 119 more hours to land (or 0 hours if there is one more approval) ✔ Last GitHub CI successful ℹ Last Full PR CI on 2023-12-26T06:37:38Z: https://ci.nodejs.org/job/node-test-pull-request/56533/ - Querying data for job/node-test-pull-request/56533/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/7341101364 |
nodejs-github-bot
added
the
commit-queue-failed
jasnell
approved these changes
Dec 27, 2023
Qard
approved these changes
Dec 28, 2023
legendecas
approved these changes
Dec 28, 2023
legendecas
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in ff6365b |
RafaelGSS
pushed a commit
that referenced
this pull request
Jan 2, 2024
PR-URL: #51287 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Merged
marco-ippolito
pushed a commit
to marco-ippolito/node
that referenced
this pull request
Jan 12, 2024
PR-URL: nodejs#51367 Refs: nodejs#51287 Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Medhansh404
pushed a commit
to Medhansh404/node
that referenced
this pull request
Jan 19, 2024
PR-URL: nodejs#51367 Refs: nodejs#51287 Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
richardlau
pushed a commit
that referenced
this pull request
Mar 25, 2024
PR-URL: #51287 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
richardlau
pushed a commit
that referenced
this pull request
Mar 25, 2024
PR-URL: #51287 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small refactor