deps: update ngtcp2 and nghttp3, update quic impls #51291
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
needs-ci
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Qard
approved these changes
Dec 27, 2023
This comment was marked as outdated.
This comment was marked as outdated.
|
I'll review this tomorrow 👍 |
gengjiawen
reviewed
Dec 27, 2023
This was referenced Dec 27, 2023
This comment was marked as outdated.
This comment was marked as outdated.
anonrig
reviewed
Dec 27, 2023
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
jasnell
added
lib / src
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/51291 ✔ Done loading data for nodejs/node/pull/51291 ----------------------------------- PR info ------------------------------------ Title deps: update ngtcp2 and nghttp3, update quic impls (#51291) Author James M Snell (@jasnell) Branch jasnell:quic-part-9 -> nodejs:main Labels lib / src, author ready, needs-ci, quic, dependencies Commits 2 - deps: update ngtcp2 and nghttp3 - quic: update quic impl to use latest ngtcp2/nghttp3 Committers 1 - James M Snell PR-URL: https://github.com/nodejs/node/pull/51291 Reviewed-By: Stephen Belanger ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/51291 Reviewed-By: Stephen Belanger -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last approving review: ⚠ - deps: update ngtcp2 and nghttp3 ⚠ - quic: update quic impl to use latest ngtcp2/nghttp3 ℹ This PR was created on Tue, 26 Dec 2023 23:30:04 GMT ✔ Approvals: 1 ✔ - Stephen Belanger (@Qard): https://github.com/nodejs/node/pull/51291#pullrequestreview-1796691870 ✘ This PR needs to wait 119 more hours to land (or 0 hours if there is one more approval) ✘ Last GitHub CI failed ℹ Last Full PR CI on 2023-12-27T19:28:53Z: https://ci.nodejs.org/job/node-test-pull-request/56565/ - Querying data for job/node-test-pull-request/56565/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/7352086887 |
gengjiawen
approved these changes
Dec 29, 2023
gengjiawen
added
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/51291 ✔ Done loading data for nodejs/node/pull/51291 ----------------------------------- PR info ------------------------------------ Title deps: update ngtcp2 and nghttp3, update quic impls (#51291) Author James M Snell (@jasnell) Branch jasnell:quic-part-9 -> nodejs:main Labels lib / src, author ready, needs-ci, quic, dependencies Commits 2 - deps: update ngtcp2 and nghttp3 - quic: update quic impl to use latest ngtcp2/nghttp3 Committers 1 - James M Snell PR-URL: https://github.com/nodejs/node/pull/51291 Reviewed-By: Stephen Belanger Reviewed-By: Jiawen Geng ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/51291 Reviewed-By: Stephen Belanger Reviewed-By: Jiawen Geng -------------------------------------------------------------------------------- ℹ This PR was created on Tue, 26 Dec 2023 23:30:04 GMT ✔ Approvals: 2 ✔ - Stephen Belanger (@Qard): https://github.com/nodejs/node/pull/51291#pullrequestreview-1796691870 ✔ - Jiawen Geng (@gengjiawen): https://github.com/nodejs/node/pull/51291#pullrequestreview-1798809500 ✘ Last GitHub CI failed ℹ Last Full PR CI on 2023-12-28T23:37:07Z: https://ci.nodejs.org/job/node-test-pull-request/56565/ - Querying data for job/node-test-pull-request/56565/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/7355913366 |
|
Landed in 07f3df4...0bf1548 |
jasnell
added a commit
that referenced
this pull request
Dec 29, 2023
PR-URL: #51291 Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
jasnell
added a commit
that referenced
this pull request
Dec 29, 2023
PR-URL: #51291 Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
RafaelGSS
pushed a commit
that referenced
this pull request
Jan 2, 2024
PR-URL: #51291 Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
RafaelGSS
pushed a commit
that referenced
this pull request
Jan 2, 2024
PR-URL: #51291 Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Merged
richardlau
added
the
dont-land-on-v20.x
richardlau
pushed a commit
that referenced
this pull request
May 10, 2024
PR-URL: #51291 Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the ngtcp2 and nghttp3 dependencies and various bits of code that rely on it.