Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quic: various additional cleanups, fixes in Endpoint #51310

Closed
wants to merge 8 commits into from

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented Dec 29, 2023

More incremental implementation of quic/http3

Adds debug logging details, starts to add the http3 internal impl

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/gyp

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Dec 29, 2023
@jasnell jasnell added the quic Issues and PRs related to the QUIC implementation / HTTP/3. label Dec 29, 2023
src/quic/tlscontext.h Outdated Show resolved Hide resolved
@jasnell jasnell force-pushed the quic-part-10 branch 4 times, most recently from 10c3f63 to dee88f8 Compare December 29, 2023 22:10
@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

This comment was marked as outdated.

Copy link
Member

@Qard Qard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did a quick skim and left some comments. Will have to find time for a more in-depth review another time.

src/quic/http3.cc Show resolved Hide resolved
src/quic/http3.cc Outdated Show resolved Hide resolved
@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 31, 2023

@jasnell jasnell added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed needs-ci PRs that need a full CI run. labels Jan 1, 2024
jasnell added a commit that referenced this pull request Jan 6, 2024
PR-URL: #51310
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
@jasnell
Copy link
Member Author

jasnell commented Jan 6, 2024

Landed in 3605574

@jasnell jasnell closed this Jan 6, 2024
marco-ippolito pushed a commit to marco-ippolito/node that referenced this pull request Jan 12, 2024
PR-URL: nodejs#51310
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Medhansh404 pushed a commit to Medhansh404/node that referenced this pull request Jan 19, 2024
PR-URL: nodejs#51310
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
targos pushed a commit that referenced this pull request Feb 15, 2024
PR-URL: #51310
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
@marco-ippolito marco-ippolito mentioned this pull request Mar 1, 2024
@marco-ippolito marco-ippolito added the dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. label May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. lib / src Issues and PRs related to general changes in the lib or src directory. quic Issues and PRs related to the QUIC implementation / HTTP/3.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants