Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: improve subtests documentation #51379

Merged
merged 1 commit into from
Jan 7, 2024
Merged

doc: improve subtests documentation #51379

merged 1 commit into from
Jan 7, 2024

Conversation

marco-ippolito
Copy link
Member

Fixes: #51359

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/test_runner

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. test_runner Issues and PRs related to the test runner subsystem. labels Jan 5, 2024
MoLow
MoLow approved these changes Jan 6, 2024
View reviewed changes
Copy link
Member

@MoLow MoLow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@MoLow MoLow added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Jan 6, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 7, 2024
@nodejs-github-bot nodejs-github-bot merged commit 387490a into nodejs:main Jan 7, 2024
26 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 387490a

marco-ippolito added a commit to marco-ippolito/node that referenced this pull request Jan 12, 2024
@marco-ippolito
doc: improve subtests documentation
7e161e4 
PR-URL: nodejs#51379
Fixes: nodejs#51359
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Medhansh404 pushed a commit to Medhansh404/node that referenced this pull request Jan 19, 2024
@marco-ippolito @Medhansh404
doc: improve subtests documentation
7d7be80 
PR-URL: nodejs#51379
Fixes: nodejs#51359
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
targos pushed a commit that referenced this pull request Feb 15, 2024
@marco-ippolito @targos
doc: improve subtests documentation
d7658ca 
PR-URL: #51379
Fixes: #51359
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
@marco-ippolito marco-ippolito mentioned this pull request Mar 1, 2024
Merged
richardlau pushed a commit that referenced this pull request Mar 25, 2024
@marco-ippolito @richardlau
doc: improve subtests documentation
c23ee35 
PR-URL: #51379
Fixes: #51359
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
richardlau pushed a commit that referenced this pull request Mar 25, 2024
@marco-ippolito @richardlau
doc: improve subtests documentation
f301f82 
PR-URL: #51379
Fixes: #51359
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
@richardlau richardlau mentioned this pull request Mar 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjamingr benjamingr benjamingr approved these changes

@lpinca lpinca lpinca approved these changes

@MoLow MoLow MoLow approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. test_runner Issues and PRs related to the test runner subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

What is the use case of sub tests
5 participants
@marco-ippolito @nodejs-github-bot @benjamingr @lpinca @MoLow