Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

benchmark: update interations of async_hooks/async-local-storage- #51433

Conversation

lucshi
Copy link
Contributor

@lucshi lucshi commented Jan 11, 2024

getstore-nested-run.js

Fixed: #50571

The original case does not test the real performance of aync hooks. Most of time is cost by loading the test case JS file. After applying this PR, the test case makes sense. The new value is big but was tested out to be the least value to make the test case right.

<style> </style>
    after PR before PR benefit
async_hooks/async-local-storage-getstore-nested-run.js sotrageCount=1: 147505587.6 32252498.36 457%
async_hooks/async-local-storage-getstore-nested-run.js sotrageCount=10: 148090789.8 32513780.15 455%
async_hooks/async-local-storage-getstore-nested-run.js sotrageCount=100: 38733684.16 23503038.59 165%

@nodejs-github-bot nodejs-github-bot added async_hooks Issues and PRs related to the async hooks subsystem. benchmark Issues and PRs related to the benchmark subsystem. labels Jan 11, 2024
@lucshi lucshi closed this Feb 29, 2024
@lucshi lucshi deleted the async_hooks/async-local-storage-getstore-nested-run.js branch February 29, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
async_hooks Issues and PRs related to the async hooks subsystem. benchmark Issues and PRs related to the benchmark subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The performance gap between node16 and node21 changes as the n of the benchmark changes
2 participants