suppress the output of rd %config% #51437
Conversation
nodejs-github-bot
added
build
|
cc @nodejs/build-files |
|
cc @nodejs/platform-windows |
github-actions
bot
removed
the
request-ci
|
@H4ad Hi, could we merge the pull request. I noticed some warnings/errors as follows in https://ci.nodejs.org/job/node-test-commit/67906/console, but I couldn't help to fix it. |
vcbuild.bat
Outdated
| :: Suppress "The system cannot find the file specified." on every clean build. | ||
| rd %config% > nul 2> nul |
There was a problem hiding this comment.
Would something like this work instead to not suppress other errors?
| :: Suppress "The system cannot find the file specified." on every clean build. | |
| rd %config% > nul 2> nul | |
| if exists %config% rd %config% |
There was a problem hiding this comment.
The correct syntax should be
"IF EXIST file command". However, check whether the file exists doesn't help a lot here because it's safe to remove the link even the link doesn't exists. Both of them works, and RD directly is just more simpler IMO.
There was a problem hiding this comment.
On the other hand, if %config% doesn't exist, it's not necessary to invoke rd, and when it does exist, this approach doesn't silently ignore the output of rd.
There was a problem hiding this comment.
Yes, I updated this pr. Thanks! 😄
github-actions
bot
removed
the
request-ci
liudonghua123
force-pushed
the
fix_rd_confusing_error_like_message
branch
from
62c3e0a
to
79efff7
Compare
github-actions
bot
removed
the
request-ci
|
Note @ whoever decides to merge this: the commit queue would incorrectly use the first commit message as the final commit message, so either land this manually or force-push to the PR branch with an amended commit message (but that requires a fresh CI). |
@tniessen so what should I do? Amend the two commits into one, change the commit message then force-push? |
|
That option would be the easiest solution for us, then we only need to re-run CI on the squashed commit :) |
liudonghua123
force-pushed
the
fix_rd_confusing_error_like_message
branch
from
79efff7
to
2f328c0
Compare
|
@tniessen Thanks, now I reset the last two commits and force pushed the amended log message commit. |
|
Thank you @liudonghua123! |
github-actions
bot
removed
the
request-ci
lpinca
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in b9a4279 |
PR-URL: nodejs#51437 Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: nodejs#51437 Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #51437 Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: nodejs#51437 Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #51437 Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #51437 Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
I noticed the confusing error like message
The system cannot find the file specified.in the CIs and on my first build locally. It's really annoying.And after some debugging, I found the root case of this error message.
Then this simple pr comes for it!
See also #40749 (comment).