Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: terminate correctly double-quote in env variable #51510

Merged
merged 1 commit into from
Jan 20, 2024
Merged

src: terminate correctly double-quote in env variable #51510

merged 1 commit into from
Jan 20, 2024

Conversation

marco-ippolito
Copy link
Member

Fixes: #51508

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Jan 18, 2024
@marco-ippolito marco-ippolito changed the title src: terminate correctly inline comment in env variable src: terminate correctly double-quote in env variable Jan 18, 2024
@marco-ippolito marco-ippolito added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 18, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 18, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56831/

@debadree25 debadree25 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 18, 2024
@anonrig anonrig added the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 18, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 20, 2024
@nodejs-github-bot nodejs-github-bot merged commit 880c90c into nodejs:main Jan 20, 2024
56 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 880c90c

marco-ippolito added a commit to marco-ippolito/node that referenced this pull request Feb 2, 2024
@marco-ippolito
src: terminate correctly double-quote in env variable
8112293 
PR-URL: nodejs#51510
Fixes: nodejs#51508
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
targos pushed a commit that referenced this pull request Feb 15, 2024
@marco-ippolito @targos
src: terminate correctly double-quote in env variable
e3a6384 
PR-URL: #51510
Fixes: #51508
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
marco-ippolito added a commit to marco-ippolito/node that referenced this pull request Feb 19, 2024
@marco-ippolito
src: terminate correctly double-quote in env variable
b8e5f51 
PR-URL: nodejs#51510
Fixes: nodejs#51508
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@marco-ippolito marco-ippolito mentioned this pull request Mar 1, 2024
Merged
richardlau pushed a commit that referenced this pull request Mar 25, 2024
@marco-ippolito @richardlau
src: terminate correctly double-quote in env variable
b745d87 
PR-URL: #51510
Fixes: #51508
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
richardlau pushed a commit that referenced this pull request Mar 25, 2024
@marco-ippolito @richardlau
src: terminate correctly double-quote in env variable
a5afad2 
PR-URL: #51510
Fixes: #51508
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@richardlau richardlau mentioned this pull request Mar 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjamingr benjamingr benjamingr approved these changes

@anonrig anonrig anonrig approved these changes

@debadree25 debadree25 debadree25 approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

--env-file parses commented out parts, when they contain quotation marks
5 participants
@marco-ippolito @nodejs-github-bot @benjamingr @anonrig @debadree25