Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v21.x backport] url: don't update URL immediately on update to URLSearchParams #51559

Merged
merged 1 commit into from
Feb 15, 2024
Merged

[v21.x backport] url: don't update URL immediately on update to URLSearchParams #51559

merged 1 commit into from
Feb 15, 2024

Conversation

MattIPv4
Copy link
Member

Backport for #51520, fixing the commit message to match the PR title rather than the misleading initial commit message.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/url

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. v21.x whatwg-url Issues and PRs related to the WHATWG URL implementation. labels Jan 24, 2024
@MattIPv4
url: don't update URL immediately on update to URLSearchParams
6e04e1f 
PR-URL: nodejs#51520
Fixes: nodejs#51518
Backport-PR-URL: nodejs#51559
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@targos targos merged commit 407341e into nodejs:v21.x-staging Feb 15, 2024
20 checks passed
@targos
Copy link
Member

targos commented Feb 15, 2024 •
edited
Loading

Thank you! Since the only change compared to what's on main is the commit message, I merged the PR directly.

richardlau pushed a commit that referenced this pull request Mar 25, 2024
@MattIPv4 @richardlau
url: don't update URL immediately on update to URLSearchParams
fdc2619 
PR-URL: #51520
Fixes: #51518
Backport-PR-URL: #51559
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
richardlau pushed a commit that referenced this pull request Mar 25, 2024
@MattIPv4 @richardlau
url: don't update URL immediately on update to URLSearchParams
4bc8e98 
PR-URL: #51520
Fixes: #51518
Backport-PR-URL: #51559
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
needs-ci PRs that need a full CI run. whatwg-url Issues and PRs related to the WHATWG URL implementation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@MattIPv4 @nodejs-github-bot @targos