node-api: make tsfn accept napi_finalize once more #51801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
c++
github-actions
bot
removed
the
request-ci
gabrielschulhof
force-pushed
the
tsfn-undo-nogc-finalizer
branch
from
6957cd6
to
b098fc1
Compare
legendecas
approved these changes
Feb 22, 2024
The thread-safe function's finalizer is not called in conjunction with the garbage collection of a JS value. In fact, it keeps a strong reference to the JS function it is expected to call. Thus, it is safe to make calls that affect GC state from its body.
gabrielschulhof
force-pushed
the
tsfn-undo-nogc-finalizer
branch
from
b098fc1
to
9a9266c
Compare
gabrielschulhof
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
nodejs-github-bot
added
the
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/51801 ✔ Done loading data for nodejs/node/pull/51801 ----------------------------------- PR info ------------------------------------ Title node-api: make tsfn accept napi_finalize once more (#51801) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch gabrielschulhof:tsfn-undo-nogc-finalizer -> nodejs:main Labels c++, node-api Commits 1 - node-api: make tsfn accept napi_finalize once more Committers 1 - Gabriel Schulhof PR-URL: https://github.com/nodejs/node/pull/51801 Reviewed-By: Michael Dawson Reviewed-By: Chengzhong Wu ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/51801 Reviewed-By: Michael Dawson Reviewed-By: Chengzhong Wu -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last approving review: ⚠ - node-api: make tsfn accept napi_finalize once more ℹ This PR was created on Sun, 18 Feb 2024 17:08:52 GMT ✔ Approvals: 2 ✔ - Michael Dawson (@mhdawson) (TSC): https://github.com/nodejs/node/pull/51801#pullrequestreview-1890738462 ✔ - Chengzhong Wu (@legendecas) (TSC): https://github.com/nodejs/node/pull/51801#pullrequestreview-1894793505 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2024-03-08T05:35:24Z: https://ci.nodejs.org/job/node-test-pull-request/57629/ - Querying data for job/node-test-pull-request/57629/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/8206250115 |
|
@legendecas, @mhdawson can you please give the PR another look? |
gabrielschulhof
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in f0e6acd |
mhdawson
added
lts-watch-v18.x
rdw-msft
pushed a commit
to rdw-msft/node
that referenced
this pull request
Mar 26, 2024
The thread-safe function's finalizer is not called in conjunction with the garbage collection of a JS value. In fact, it keeps a strong reference to the JS function it is expected to call. Thus, it is safe to make calls that affect GC state from its body. PR-URL: nodejs#51801 Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
This was referenced Apr 12, 2024
marco-ippolito
pushed a commit
that referenced
this pull request
May 2, 2024
The thread-safe function's finalizer is not called in conjunction with the garbage collection of a JS value. In fact, it keeps a strong reference to the JS function it is expected to call. Thus, it is safe to make calls that affect GC state from its body. PR-URL: #51801 Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The thread-safe function's finalizer is not called in conjunction with the garbage collection of a JS value. In fact, it keeps a strong reference to the JS function it is expected to call. Thus, it is safe to make calls that affect GC state from its body.