Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: fix installing node with shared mode #51910

Merged
merged 1 commit into from Mar 1, 2024
Merged

tools: fix installing node with shared mode #51910

merged 1 commit into from Mar 1, 2024

Conversation

zcbenz
Copy link
Contributor

@zcbenz zcbenz commented Feb 28, 2024

Fix a bug caused by #50737 that, make install fails for --shared mode.

This was reported by #50737 (comment).

@zcbenz
tools: fix installing node with shared mode
a0e52cb 
Fix a bug caused by nodejs#50737 that,
make install fails for --shared mode.
@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. python PRs and issues that require attention from people who are familiar with Python. labels Feb 28, 2024
@8JUFtKyf5wQnBAF

This comment was marked as spam.

Sign in to view
@richardlau richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 28, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 28, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57488/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57491/

@richardlau richardlau added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 28, 2024
@richardlau richardlau added the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 28, 2024
@batrla
Copy link
Contributor

batrla commented Feb 29, 2024

Thanks for quick fix, node in --shared mode builds again!

@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 1, 2024
@nodejs-github-bot nodejs-github-bot merged commit 6aa1d98 into nodejs:main Mar 1, 2024
64 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 6aa1d98

@richardlau richardlau mentioned this pull request Mar 1, 2024
Merged
marco-ippolito pushed a commit that referenced this pull request Mar 1, 2024
@zcbenz @marco-ippolito
tools: fix installing node with shared mode
0711e3b 
Fix a bug caused by #50737 that,
make install fails for --shared mode.

PR-URL: #51910
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
marco-ippolito pushed a commit that referenced this pull request Mar 1, 2024
@zcbenz @marco-ippolito
tools: fix installing node with shared mode
27f8549 
Fix a bug caused by #50737 that,
make install fails for --shared mode.

PR-URL: #51910
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
richardlau pushed a commit that referenced this pull request Mar 25, 2024
@zcbenz @richardlau
tools: fix installing node with shared mode
818afbd 
Fix a bug caused by #50737 that,
make install fails for --shared mode.

PR-URL: #51910
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
richardlau pushed a commit that referenced this pull request Mar 25, 2024
@zcbenz @richardlau
tools: fix installing node with shared mode
f4ac7ba 
Fix a bug caused by #50737 that,
make install fails for --shared mode.

PR-URL: #51910
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@richardlau richardlau mentioned this pull request Mar 25, 2024
Merged
rdw-msft pushed a commit to rdw-msft/node that referenced this pull request Mar 26, 2024
@zcbenz @rdw-msft
tools: fix installing node with shared mode
7e6614b 
Fix a bug caused by nodejs#50737 that,
make install fails for --shared mode.

PR-URL: nodejs#51910
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@richardlau richardlau richardlau approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. python PRs and issues that require attention from people who are familiar with Python.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@zcbenz @8JUFtKyf5wQnBAF @nodejs-github-bot @batrla @lpinca @richardlau