tools: install npm PowerShell scripts on Windows #52009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
npm 9.8.0 added PowerShell scripts that should be installed alongside the cmd and shell scripts on Windows. Fixes: #48471 Refs: npm/cli#6548
nodejs-github-bot
added
build
|
@nodejs/platform-windows |
lpinca
approved these changes
Mar 8, 2024
github-actions
bot
removed
the
request-ci
|
Hey @lukekarrys I worked on the Node.js MSI installer some time ago. I'll check this PR once I get some free cycles. I'll share my findings afterward. |
StefanStojanovic
approved these changes
Mar 18, 2024
There was a problem hiding this comment.
@lukekarrys I've tried the installer locally. I've tried all the regular installation stuff - install, change, repair, etc. All cases worked as expected.
For me, this looks good, and thanks for adding it!
lpinca
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 4d86020 |
richardlau
added
lts-watch-v18.x
2 tasks
targos
added
the
baking-for-lts
|
Added
baking-for-lts
|
marco-ippolito
pushed a commit
that referenced
this pull request
May 2, 2024
npm 9.8.0 added PowerShell scripts that should be installed alongside the cmd and shell scripts on Windows. Fixes: #48471 Refs: npm/cli#6548 PR-URL: #52009 Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
marco-ippolito
pushed a commit
that referenced
this pull request
May 3, 2024
npm 9.8.0 added PowerShell scripts that should be installed alongside the cmd and shell scripts on Windows. Fixes: #48471 Refs: npm/cli#6548 PR-URL: #52009 Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
npm 9.8.0 added PowerShell scripts that should be installed alongside the cmd and shell scripts on Windows.
All current versions of Node.js ship with npm@10 so this change should be safe to land.
I am not well versed in Windows development so I am not sure how this change should tested, and would like pointers on how to best to that.
I also want to add that there have been requests on the npm repo that PowerShell be made the default (npm/cli#6789). From my understanding, that is up to a user configuration but will now be possible by including these files. I plan to close that issue if this is merged unless there is follow-up work to somehow change the default which I think would need a different discussion.
Closes: #48471
Ref: npm/cli#6548