Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: optimize the doc about Unix abstract socket #52043

Merged
merged 1 commit into from
Mar 19, 2024
Merged

doc: optimize the doc about Unix abstract socket #52043

merged 1 commit into from
Mar 19, 2024

Conversation

theanarkh
Copy link
Contributor

optimize the doc about Unix abstract socket

Refs: #50904

  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/net

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. net Issues and PRs related to the net subsystem. labels Mar 11, 2024
@theanarkh theanarkh mentioned this pull request Mar 11, 2024
Merged
4 tasks
ShogunPanda
ShogunPanda reviewed Mar 11, 2024
View reviewed changes
doc/api/net.md Outdated Show resolved Hide resolved
VoltrexKeyva
VoltrexKeyva reviewed Mar 11, 2024
View reviewed changes
doc/api/net.md Outdated Show resolved Hide resolved
ShogunPanda
ShogunPanda approved these changes Mar 11, 2024
View reviewed changes
Copy link
Contributor

@ShogunPanda ShogunPanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Little nit but rest LGTM.

@theanarkh theanarkh added the fast-track PRs that do not need to wait for 48 hours to land. label Mar 12, 2024
@github-actions GitHub Actions
Copy link
Contributor

Fast-track has been requested by @theanarkh. Please 👍 to approve.

legendecas
legendecas requested changes Mar 13, 2024
View reviewed changes
doc/api/net.md Outdated Show resolved Hide resolved
@theanarkh theanarkh removed the fast-track PRs that do not need to wait for 48 hours to land. label Mar 13, 2024
@theanarkh theanarkh added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 19, 2024
mcollina
mcollina approved these changes Mar 19, 2024
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina added the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 19, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 19, 2024
@nodejs-github-bot nodejs-github-bot merged commit 7071554 into nodejs:main Mar 19, 2024
18 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 7071554

rdw-msft pushed a commit to rdw-msft/node that referenced this pull request Mar 26, 2024
@theanarkh @rdw-msft
doc: optimize the doc about Unix abstract socket
26a34df 
PR-URL: nodejs#52043
Refs: nodejs#50904
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@RafaelGSS RafaelGSS mentioned this pull request Apr 15, 2024
Merged
marco-ippolito pushed a commit that referenced this pull request May 2, 2024
@theanarkh @marco-ippolito
doc: optimize the doc about Unix abstract socket
7857cfb 
PR-URL: #52043
Refs: #50904
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@marco-ippolito marco-ippolito mentioned this pull request May 2, 2024
Merged
marco-ippolito pushed a commit that referenced this pull request May 3, 2024
@theanarkh @marco-ippolito
doc: optimize the doc about Unix abstract socket
bda3cde 
PR-URL: #52043
Refs: #50904
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VoltrexKeyva VoltrexKeyva VoltrexKeyva left review comments

@mcollina mcollina mcollina approved these changes

@ShogunPanda ShogunPanda ShogunPanda approved these changes

@lpinca lpinca lpinca approved these changes

@legendecas legendecas legendecas approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. net Issues and PRs related to the net subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@theanarkh @nodejs-github-bot @mcollina @ShogunPanda @lpinca @legendecas @VoltrexKeyva