stream: add new when constructing ERR_MULTIPLE_CALLBACK
#52110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
ronag
approved these changes
Mar 16, 2024
debadree25
approved these changes
Mar 16, 2024
debadree25
added
author ready
github-actions
bot
removed
the
request-ci
lpinca
approved these changes
Mar 16, 2024
test/parallel/test-stream-err-multiple-callback-construction.js
Outdated
Show resolved
Hide resolved
lpinca
reviewed
Mar 16, 2024
test/parallel/test-stream-err-multiple-callback-construction.js
Outdated
Show resolved
Hide resolved
lpinca
approved these changes
Mar 16, 2024
haze
force-pushed
the
pr/hb/err-multiple-callback-fix
branch
from
e30cf1e
to
dcdcf76
Compare
lpinca
approved these changes
Mar 16, 2024
test/parallel/test-stream-err-multiple-callback-construction.js
Outdated
Show resolved
Hide resolved
lpinca
approved these changes
Mar 16, 2024
lpinca
added
commit-queue-squash
github-actions
bot
removed
the
request-ci
commit c71e548 changed NodeError from a function to a class, and missed a spot where `ERR_MULTIPLE_CALLBACK` was being instantiated. This commit fixes that by adding the new keyword to that instance. Co-authored-by: Luigi Pinca <luigipinca@gmail.com>
haze
force-pushed
the
pr/hb/err-multiple-callback-fix
branch
from
f3e8260
to
a5a3fd7
Compare
github-actions
bot
removed
the
request-ci
atlowChemi
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
Commit Queue failed- Loading data for nodejs/node/pull/52110 ✔ Done loading data for nodejs/node/pull/52110 ----------------------------------- PR info ------------------------------------ Title stream: add `new` when constructing `ERR_MULTIPLE_CALLBACK` (#52110) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch haze:pr/hb/err-multiple-callback-fix -> nodejs:main Labels author ready, needs-ci, commit-queue-squash Commits 1 - stream: add `new` when constructing `ERR_MULTIPLE_CALLBACK` Committers 1 - Haze Booth PR-URL: https://github.com/nodejs/node/pull/52110 Reviewed-By: Robert Nagy Reviewed-By: Debadree Chatterjee Reviewed-By: Luigi Pinca ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/52110 Reviewed-By: Robert Nagy Reviewed-By: Debadree Chatterjee Reviewed-By: Luigi Pinca -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last approving review: ⚠ - stream: add `new` when constructing `ERR_MULTIPLE_CALLBACK` ℹ This PR was created on Sat, 16 Mar 2024 03:29:48 GMT ✔ Approvals: 3 ✔ - Robert Nagy (@ronag) (TSC): https://github.com/nodejs/node/pull/52110#pullrequestreview-1940941832 ✔ - Debadree Chatterjee (@debadree25): https://github.com/nodejs/node/pull/52110#pullrequestreview-1940956860 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/52110#pullrequestreview-1941334372 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2024-03-17T06:35:38Z: https://ci.nodejs.org/job/node-test-pull-request/57784/ - Querying data for job/node-test-pull-request/57784/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/8320924494 |
nodejs-github-bot
added
the
commit-queue-failed
mcollina
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 63391e7 |
|
@nodejs/releasers could you include this in the upcoming v18.x release? |
It would break with policy because this hasn't gone out in a current release yet (default policy is that things should be in current for two weeks before going into an LTS line). I'm also confused -- according to the description, this PR fixes an issue introduced by c71e548 which is #49654 and that isn't on v18.x. 😕 |
rdw-msft
pushed a commit
to rdw-msft/node
that referenced
this pull request
Mar 26, 2024
commit c71e548 changed NodeError from a function to a class, and missed a spot where `ERR_MULTIPLE_CALLBACK` was being instantiated. This commit fixes that by adding the new keyword to that instance. Co-authored-by: Luigi Pinca <luigipinca@gmail.com> PR-URL: nodejs#52110 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Debadree Chatterjee <debadree333@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
|
@richardlau is this a candidate for v20.x? |
|
It needs to be released in a Node.js current release (either 21 or 22 when it arrives next month) before it can land in 20.x. |
marco-ippolito
pushed a commit
that referenced
this pull request
May 2, 2024
commit c71e548 changed NodeError from a function to a class, and missed a spot where `ERR_MULTIPLE_CALLBACK` was being instantiated. This commit fixes that by adding the new keyword to that instance. Co-authored-by: Luigi Pinca <luigipinca@gmail.com> PR-URL: #52110 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Debadree Chatterjee <debadree333@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Merged
marco-ippolito
pushed a commit
that referenced
this pull request
May 3, 2024
commit c71e548 changed NodeError from a function to a class, and missed a spot where `ERR_MULTIPLE_CALLBACK` was being instantiated. This commit fixes that by adding the new keyword to that instance. Co-authored-by: Luigi Pinca <luigipinca@gmail.com> PR-URL: #52110 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Debadree Chatterjee <debadree333@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
richardlau
removed
the
lts-watch-v18.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
commit c71e548 changed NodeError from a function to a class, and missed a spot where
ERR_MULTIPLE_CALLBACKwas being instantiated. This commit fixes that by adding the new keyword to that instance.